Re: [PATCH 7/9] hw/net: Have eTSEC device inherit from DYNAMIC_SYS_BUS_DEVICE

[Bernhard Beschow]

Am 25. Januar 2025 18:13:41 UTC schrieb "Philippe Mathieu-Daudé" 
<philmd@linaro.org>:
>Because the network eTSEC device can be optionally plugged on the
>TYPE_PLATFORM_BUS_DEVICE, have it inherit TYPE_DYNAMIC_SYS_BUS_DEVICE.
>
>Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Tested-by: Bernhard Beschow <shentey@gmail.com>
Acked-by: Bernhard Beschow <shentey@gmail.com>

>---
> hw/net/fsl_etsec/etsec.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c
>index 781b9003954..3ce4fa2662d 100644
>--- a/hw/net/fsl_etsec/etsec.c
>+++ b/hw/net/fsl_etsec/etsec.c
>@@ -425,14 +425,12 @@ static void etsec_class_init(ObjectClass *klass, void 
>*data)
>     dc->realize = etsec_realize;
>     device_class_set_legacy_reset(dc, etsec_reset);
>     device_class_set_props(dc, etsec_properties);
>-    /* Supported by ppce500 machine */
>-    dc->user_creatable = true;
> }
> 
> static const TypeInfo etsec_types[] = {
>     {
>         .name          = TYPE_ETSEC_COMMON,
>-        .parent        = TYPE_SYS_BUS_DEVICE,
>+        .parent        = TYPE_DYNAMIC_SYS_BUS_DEVICE,
>         .instance_size = sizeof(eTSEC),
>         .class_init    = etsec_class_init,
>         .instance_init = etsec_instance_init,