Re: [PATCH v1 1/3] hw/s390x: add SCLP event type CPI

[Nina Schoetterl-Glausch]

Please swap patch 1 and 2 and incorporate the changes of write_event_data
into this patch.

Reviewed-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>

See some minor nits below.

On Wed, 2025-01-15 at 14:31 +0100, Shalini Chellathurai Saroja wrote:
> This commit implements the SCLP event type Control-Program
> Identification in QEMU. Control-program is an IBM term for
> operating system. This event is used to send firmware
> program identifiers from KVM guest to SCLP. The program

This event is used to send information about the guest OS
to the host.

> identifiers provide data about the guest OS. The program
> identifiers are system type, system name, system level and

identifiers are: ...
> sysplex name.
> 
> System type provides the OS type of the guest. System name
> provides the name of the guest. System level provides the
> distribution and kernel version of the guest OS.  Sysplex
> name provides sysplex name of the guest.

The system type provides the OS type of the guest (e.g. LINUX).
The system name provides the name of the guest (e.g. TESTVM).
The system level provides the distribution and kernel version of the guest OS 
(e.g. 0x50e00).
The sysplex name provides the sysplex name of the guest (e.g. SYSPLEX).

> 
> Signed-off-by: Shalini Chellathurai Saroja <shalini@linux.ibm.com>
> ---
>  hw/s390x/event-facility.c         | 12 +++-
>  hw/s390x/meson.build              |  1 +
>  hw/s390x/sclpcpi.c                | 94 +++++++++++++++++++++++++++++++
>  include/hw/s390x/event-facility.h |  3 +
>  4 files changed, 109 insertions(+), 1 deletion(-)
>  create mode 100644 hw/s390x/sclpcpi.c
> 
[...]
> 
> diff --git a/hw/s390x/sclpcpi.c b/hw/s390x/sclpcpi.c
> new file mode 100644
> index 0000000000..64bc730f47
> --- /dev/null
> +++ b/hw/s390x/sclpcpi.c
> @@ -0,0 +1,94 @@
> +/*
> + * SCLP event type 11 - Control-Program Identification(CPI):
> + *    CPI is used to send program identifiers from control-program to the 
> SCLP.

...from the control-program...

> + *    The program identifiers provide data about Linux instance. It is not 
> sent

... about the guest instance...

> + *    by the SCLP.
> + *
> + *    The program identifiers are system type, system name, sysplex name and
> + *    system level. The system type, system name, and sysplex name use EBCDIC
> + *    ucharacters from this set: capital A-Z, 0-9, $, @, #, and blank. The
> + *    system level is hex value.

... is a hex value...
(Well I guess it's just a number)

> + *
> + * Copyright IBM, Corp. 2024
> + *
> + * Authors:
> + *  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or (at 
> your
> + * option) any later version.  See the COPYING file in the top-level 
> directory.
> + *
> + */
> +
[...]