Re: [PATCH] hpet: do not overwrite properties on post_load

[Zhao Liu]

This patch was missed :-) which could free HPETState.flags from a
BqlCell.

> > -    /* Push number of timers into capability returned via HPET_ID */
> > -    s->capability &= ~HPET_ID_NUM_TIM_MASK;
> > -    s->capability |= (s->num_timers - 1) << HPET_ID_NUM_TIM_SHIFT;
> > -    hpet_cfg.hpet[s->hpet_id].event_timer_block_id = 
> > (uint32_t)s->capability;
> > -
> > -    /* Derive HPET_MSI_SUPPORT from the capability of the first timer. */
> > -    s->flags &= ~(1 << HPET_MSI_SUPPORT);
> > -    if (s->timer[0].config & HPET_TN_FSB_CAP) {
> > -        s->flags |= 1 << HPET_MSI_SUPPORT;
> 
> About the MSI (FSB) support, I haven't seen it being used anywhere. Is it the
> dead code?
> 

I have this question since I find it seems no way to set "msi" and
"timers" properties by user, and no code sets them.

    DEFINE_PROP_UINT8("timers", HPETState, num_timers, HPET_MIN_TIMERS),
    DEFINE_PROP_BIT("msi", HPETState, flags, HPET_MSI_SUPPORT, false),

Thanks,
Zhao