Re: [v7 00/26] vfio-user client

[Cédric Le Goater]

Hello John,

On 1/23/25 11:11, John Levon wrote:
> On Wed, Jan 08, 2025 at 11:50:06AM +0000, John Levon wrote:
>
> > Hi, this is the 7th revision of the vfio-user client implementation.
> >
> > First of all, thank you for your time reviewing the previous versions.
> >
> > The vfio-user framework consists of 3 parts:
> >   1) The VFIO user protocol specification.
> >   2) A client - the VFIO device in QEMU that encapsulates VFIO messages
> >      and sends them to the server.
> >   3) A server - a remote process that emulates a device.
> >
> > This patchset implements parts 1 and 2.
> >
> > It has been tested against libvfio-user test servers as well as SPDK.
>
> Ping, would appreciate any review comments

Well, among the reasons why we tend to push this at end of
the list are :

  - the respins are spaced over time (1 a year ?)
  - it's invasive in an already very complex subsystem
  - it's HUGE. See the diffstat below ...

I would introduce a new hw/vfio-user/ subsystem given the size.
The commit logs are short. Most are one liners, this is really
not much for such a big change.

Any how, I hope to take a look before the end of 10.0 cycle.

Thanks,

C.


 MAINTAINERS                           |   11
 docs/devel/index-internals.rst        |    1
 docs/devel/vfio-user.rst              | 1522 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 hw/vfio/ap.c                          |    4
 hw/vfio/ccw.c                         |    9
 hw/vfio/common.c                      |  131 +++++--
 hw/vfio/container-base.c              |    8
 hw/vfio/container.c                   |   78 +++-
 hw/vfio/helpers.c                     |  185 +++++++++-
 hw/vfio/igd.c                         |    8
 hw/vfio/iommufd.c                     |   31 +
 hw/vfio/meson.build                   |    5
 hw/vfio/pci.c                         |  595 ++++++++++++++++++++-------------
 hw/vfio/pci.h                         |   35 +
 hw/vfio/platform.c                    |    4
 hw/vfio/trace-events                  |   17
 hw/vfio/user-container.c              |  358 ++++++++++++++++++++
 hw/vfio/user-pci.c                    |  446 +++++++++++++++++++++++++
 hw/vfio/user-protocol.h               |  245 +++++++++++++
 hw/vfio/user.c                        | 1705 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 hw/vfio/user.h                        |  132 +++++++
 hw/virtio/vhost-vdpa.c                |    2
 include/exec/memory.h                 |    4
 include/hw/vfio/vfio-common.h         |   54 ++-
 include/hw/vfio/vfio-container-base.h |   11
 meson_options.txt                     |    2
 scripts/meson-buildoptions.sh         |    4
 system/memory.c                       |    7
 28 files changed, 5280 insertions(+), 334 deletions(-)