qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 1/4] coreaudio: Improve naming


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v5 1/4] coreaudio: Improve naming
Date: Thu, 23 Jan 2025 09:40:16 +0100
User-agent: Mozilla Thunderbird

On 23/1/25 08:18, Akihiko Odaki wrote:
coreaudio had names that are not conforming to QEMU codding style.
coreaudioVoiceOut also had some members that are prefixed with redundant
words like "output" or "audio".
Global names included "out" to tell they are specific to output devices,
but this rule was not completely enforced.
The frame size had three different names "frameSize", "bufferFrameSize",
and "frameCount".

Replace identifiers to fix these problems.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
  audio/coreaudio.m | 191 +++++++++++++++++++++++++++---------------------------
  1 file changed, 97 insertions(+), 94 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]