Re: [PATCH RESEND 0/2] rust/pl011: miscellaneous cleanups

[Zhao Liu]

On Tue, Jan 21, 2025 at 04:58:21PM +0100, Paolo Bonzini wrote:
> Date: Tue, 21 Jan 2025 16:58:21 +0100
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: Re: [PATCH RESEND 0/2] rust/pl011: miscellaneous cleanups
> 
> On 1/21/25 15:04, Zhao Liu wrote:
> > (Resend the series since it was missed on 
> > https://lore.kernel.org/qemu-devel/.)
> > 
> > Hi,
> > 
> > This series includes the following cleanups:
> > 
> >   * Patch 1: Make realize() safe to only accept immutable self
> >              reference, which is in prepare to introduce gpio bindings
> >              [1].
> > 
> >   * Patch 2: Clean up `bindings::*` for pl011, which is inspired by
> >              Paolo's comment on HPET [2].
> 
> Yep, me being lazy and not doing what I preach.
>
> Queued---please forgive me for not posting again the series that are on the
> list, just with the "use bindings::foo" conflicts resolved. :)

Thank you! I just happened to see it and clean it up.

> Also, if you have to choose please review only the final qdev/MemoryRegion
> bits; the vmstate is mostly the same and the pl011 one has less impact on
> future code.

No problem, I remember. I'll review all of them soon (I've been catching up
on some debts I owed these days).

Thanks,
Zhao