[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/5] target/riscv/csr.c: fix deadcode in aia_smode32()
From: |
Daniel Henrique Barboza |
Subject: |
[PATCH 4/5] target/riscv/csr.c: fix deadcode in aia_smode32() |
Date: |
Tue, 21 Jan 2025 15:48:46 -0300 |
Coverity reported a DEADCODE ticket in this function, as follows:
>>>> CID 1590358: Control flow issues (DEADCODE)
>>>> Execution cannot reach this statement: "return ret;".
> 380 return ret;
> 381 }
The cause is that the 'if (ret != RISCV_EXCP_NONE)' conditional is
duplicated:
ret = smstateen_acc_ok(env, 0, SMSTATEEN0_AIA);
if (ret != RISCV_EXCP_NONE) {
return ret;
}
if (ret != RISCV_EXCP_NONE) {
return ret;
}
Remove the duplication to fix the deadcode.
Resolves: Coverity CID 1590358
Fixes: dbcb6e1ccf ("target/riscv: Enable S*stateen bits for AIA")
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
---
target/riscv/csr.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/target/riscv/csr.c b/target/riscv/csr.c
index 75f21ccabb..dc0a88a0f0 100644
--- a/target/riscv/csr.c
+++ b/target/riscv/csr.c
@@ -376,10 +376,6 @@ static RISCVException aia_smode32(CPURISCVState *env, int
csrno)
return ret;
}
- if (ret != RISCV_EXCP_NONE) {
- return ret;
- }
-
return smode32(env, csrno);
}
--
2.47.1
- [PATCH 0/5] target/riscv: Coverity fixes, Daniel Henrique Barboza, 2025/01/21
- [PATCH 1/5] target/riscv/csr.c: fix deadcode in rmw_xireg(), Daniel Henrique Barboza, 2025/01/21
- [PATCH 2/5] target/riscv/csr.c: fix 'ret' deadcode in rmw_xireg(), Daniel Henrique Barboza, 2025/01/21
- [PATCH 3/5] target/riscv/csr.c: fix deadcode in rmw_xiregi(), Daniel Henrique Barboza, 2025/01/21
- [PATCH 4/5] target/riscv/csr.c: fix deadcode in aia_smode32(),
Daniel Henrique Barboza <=
- [PATCH 5/5] target/riscv/cpu_helper.c: fix bad_shift in riscv_cpu_interrupt(), Daniel Henrique Barboza, 2025/01/21
- Re: [PATCH 0/5] target/riscv: Coverity fixes, Alistair Francis, 2025/01/28