[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] gdbstub/user-target: fix gdbserver int format (%d -> %x)
|
From: |
Michael Tokarev |
|
Subject: |
Re: [PATCH v2] gdbstub/user-target: fix gdbserver int format (%d -> %x) |
|
Date: |
Tue, 21 Jan 2025 18:06:02 +0300 |
|
User-agent: |
Mozilla Thunderbird |
21.01.2025 01:28, Dominik 'Disconnect3d' Czarnota wrote:
This commit fixes an incorrect format string for formatting integers
provided to GDB when debugging a target run in QEMU user mode.
The correct format is hexadecimal for both success and errno values,
some of which can be seen here [0].
[0]
https://github.com/bminor/binutils-gdb/blob/e65a355022d0dc6b5707310876a72b5693ec0aa5/gdbserver/hostio.cc#L196-L213
Signed-off-by: Dominik 'Disconnect3d' Czarnota <dominik.b.czarnota@gmail.com>
That's much better. Thank you Dominik. Since the patch is essentially
the same, I've added R-b's by Alex and Ilya, and the suggested Fixes: tag.
Thanks,
/mjt