qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH] tests/qtest: don't step clock at start of npcm7xx period


From: Peter Maydell
Subject: Re: [RFC PATCH] tests/qtest: don't step clock at start of npcm7xx periodic IRQ test
Date: Tue, 21 Jan 2025 09:53:35 +0000

On Mon, 20 Jan 2025 at 23:52, Hao Wu <wuhaotsh@google.com> wrote:
>
> Have you tried that the test can pass with this? If I remember correctly, 
> interrupt won't trigger properly if not advancing the timer
>
> If the test passes it's probably fine to remove that.

This specific clock_step_next() call is done immediately after
resetting the timer device, so there *is* no pending interrupt.
(That's why it's a problem -- it says "step the clock forward
to the next pending timer expiry", and there is no next
pending timer expiry.)

There's another clock_step_next() just after the context
in this patch, and that one is fine, because it's after
the test enables the timer and so there will be a
next pending expiry to step forward to.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]