Re: [PATCH 2/2] hw/ipack: Remove legacy qemu_allocate_irqs() use

[Philippe Mathieu-Daudé]

On 21/1/25 08:44, Philippe Mathieu-Daudé wrote:
> No need to dynamically allocate IRQ when we know before hands
> how many we'll use. Declare the 2 of them in IPackDevice state
> and initialize them in the DeviceRealize handler.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/hw/ipack/ipack.h | 7 ++-----
>   hw/ipack/ipack.c         | 7 +++----
>   2 files changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/include/hw/ipack/ipack.h b/include/hw/ipack/ipack.h
> index cbcdda509d3..14540281496 100644
> --- a/include/hw/ipack/ipack.h
> +++ b/include/hw/ipack/ipack.h


>   struct IPackDevice {
> -    /*< private >*/
>       DeviceState parent_obj;
> -    /*< public >*/
>   
>       int32_t slot;
>       /* IRQ objects for the IndustryPack INT0# and INT1# */
> -    qemu_irq *irq;
> +    qemu_irq irq[2];

Oops forgot to commit:

  -    qemu_irq irq[2];
  +    IRQState irq[2];

>   };