[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/7] tests/qtest: don't attempt to clock_step while waiting for v
From: |
Alex Bennée |
Subject: |
[PATCH 2/7] tests/qtest: don't attempt to clock_step while waiting for virtio ISR |
Date: |
Mon, 20 Jan 2025 21:02:07 +0000 |
This replicates the changes from 92cb8f8bf6 (tests/qtest: remove
clock_steps from virtio tests) as there are no timers in the virtio
code. We still busy wait and timeout though.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/qtest/libqos/virtio-pci-modern.c | 6 ++----
tests/qtest/libqos/virtio-pci.c | 6 ++----
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/tests/qtest/libqos/virtio-pci-modern.c
b/tests/qtest/libqos/virtio-pci-modern.c
index 18d118866f..f6e3e32891 100644
--- a/tests/qtest/libqos/virtio-pci-modern.c
+++ b/tests/qtest/libqos/virtio-pci-modern.c
@@ -173,13 +173,11 @@ static bool get_config_isr_status(QVirtioDevice *d)
static void wait_config_isr_status(QVirtioDevice *d, gint64 timeout_us)
{
- QVirtioPCIDevice *dev = container_of(d, QVirtioPCIDevice, vdev);
gint64 start_time = g_get_monotonic_time();
- do {
+ while (!get_config_isr_status(d)) {
g_assert(g_get_monotonic_time() - start_time <= timeout_us);
- qtest_clock_step(dev->pdev->bus->qts, 100);
- } while (!get_config_isr_status(d));
+ }
}
static void queue_select(QVirtioDevice *d, uint16_t index)
diff --git a/tests/qtest/libqos/virtio-pci.c b/tests/qtest/libqos/virtio-pci.c
index 485b8f6b7e..002bf8b8c2 100644
--- a/tests/qtest/libqos/virtio-pci.c
+++ b/tests/qtest/libqos/virtio-pci.c
@@ -171,13 +171,11 @@ static bool
qvirtio_pci_get_config_isr_status(QVirtioDevice *d)
static void qvirtio_pci_wait_config_isr_status(QVirtioDevice *d,
gint64 timeout_us)
{
- QVirtioPCIDevice *dev = container_of(d, QVirtioPCIDevice, vdev);
gint64 start_time = g_get_monotonic_time();
- do {
+ while (!qvirtio_pci_get_config_isr_status(d)) {
g_assert(g_get_monotonic_time() - start_time <= timeout_us);
- qtest_clock_step(dev->pdev->bus->qts, 100);
- } while (!qvirtio_pci_get_config_isr_status(d));
+ }
}
static void qvirtio_pci_queue_select(QVirtioDevice *d, uint16_t index)
--
2.39.5
- [PATCH 0/7] testing/next (qtest timer stuff), Alex Bennée, 2025/01/20
- [PATCH 1/7] tests/docker: replicate the check-rust-tools-nightly CI job, Alex Bennée, 2025/01/20
- [PATCH 2/7] tests/qtest: don't attempt to clock_step while waiting for virtio ISR,
Alex Bennée <=
- [PATCH 5/7] tests/qtest: rename qtest_send_prefix and roll-up into qtest_send, Alex Bennée, 2025/01/20
- [PATCH 4/7] tests/qtest: simplify qtest_process_inbuf, Alex Bennée, 2025/01/20
- [PATCH 3/7] tests/qtest: don't step clock at start of npcm7xx periodic IRQ test, Alex Bennée, 2025/01/20
- [PATCH 6/7] tests/qtest: tighten up the checks on clock_step, Alex Bennée, 2025/01/20
- [PATCH 7/7] Revert "util/timer: avoid deadlock when shutting down", Alex Bennée, 2025/01/20
- Re: [PATCH 0/7] testing/next (qtest timer stuff), Thomas Huth, 2025/01/21