[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 0/2] target/riscv: throw debug exception before page fault
From: |
Daniel Henrique Barboza |
Subject: |
[PATCH v2 0/2] target/riscv: throw debug exception before page fault |
Date: |
Mon, 20 Jan 2025 17:49:08 -0300 |
Hi,
This second version implements the change Richard suggested in v1, i.e.
do not search for wps twice.
To do that we need to make an assumption that a watchpoint for a 64 bit
address will have size 8, in particular when the user does not set a
watchpoint size. To be consistent we also need to consider that 32 bit
CPUs would use watchpoints of size 4, which is something we're not
considering. Patch 1 was added to make things more consistent in this
regard.
Patches based on master.
Changes from v1:
- patch 1 (new):
- add watchpoints of size 4 when dealing with 32 bit addresses
- patch 2:
- instead of looking for watchpoints twice, call
cpu_check_watchpoint() and rely on fall-through in case no
watchpoints are found
- v1 link: https://mail.gnu.org/archive/html/qemu-devel/2025-01/msg03575.html
Daniel Henrique Barboza (2):
target/riscv/debug.c: use wp size = 4 for 32-bit CPUs
target/riscv: throw debug exception before page fault
target/riscv/cpu_helper.c | 19 +++++++++++++++++++
target/riscv/debug.c | 6 ++++--
2 files changed, 23 insertions(+), 2 deletions(-)
--
2.47.1