[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/2] tap: Use g_spawn_sync() and g_spawn_check_wait_status
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH v4 2/2] tap: Use g_spawn_sync() and g_spawn_check_wait_status() |
|
Date: |
Fri, 17 Jan 2025 13:08:12 +0000 |
|
User-agent: |
Mutt/2.2.13 (2024-03-09) |
On Wed, Jan 15, 2025 at 09:03:08PM +0900, Akihiko Odaki wrote:
> g_spawn_sync() (for GLib < 2.68) or g_spawn_async_with_pipes_and_fds()
> (for the newer) gives an informative message if it fails to execute
> the script instead of reporting exiting status 1.
>
> g_spawn_check_wait_status() also gives an message easier to understand
> than the raw value returned by waitpid().
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> Tested-by: Lei Yang <leiyang@redhat.com>
> ---
> net/tap.c | 220
> +++++++++++++++++++++++++++++++++-----------------------------
> 1 file changed, 117 insertions(+), 103 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|