Re: [PATCH-for-10.1 v2 00/13] hw/arm: Remove virt-2.6 up to virt-2.12 machines

[Thomas Huth]

On 17/01/2025 09.09, Daniel P. Berrangé wrote:
> On Fri, Jan 17, 2025 at 07:47:15AM +0100, Thomas Huth wrote:
> > On 16/01/2025 22.13, Philippe Mathieu-Daudé wrote:
> > > Hi Peter,
> > >
> > > On 16/1/25 15:59, Philippe Mathieu-Daudé wrote:
> > > > The versioned 'virt' machines up to 2.12 been marked as deprecated
> > > > two releases ago, and are older than 6 years, so according to our
> > > > support policy we can remove them. Remove associated dead code.
> > >
> > > > Philippe Mathieu-Daudé (13):
> > > >     hw/arm/virt: Remove deprecated virt-2.6 machine
> > > >     hw/arm/virt: Remove VirtMachineClass::no_pmu field
> > > >     hw/arm/virt: Remove VirtMachineClass::disallow_affinity_adjustment
> > > >     hw/arm/virt: Remove deprecated virt-2.7 machine
> > > >     hw/arm/virt: Remove VirtMachineClass::no_its field
> > > >     hw/arm/virt: Remove deprecated virt-2.8 machine
> > > >     hw/arm/virt: Remove VirtMachineClass::claim_edge_triggered_timers
> > > >       field
> > > >     hw/arm/virt: Remove deprecated virt-2.9 machine
> > > >     hw/arm/virt: Remove deprecated virt-2.10 machine
> > > >     hw/arm/virt: Remove deprecated virt-2.11 machine
> > > >     hw/arm/virt: Remove VirtMachineClass::smbios_old_sys_ver field
> > > >     hw/arm/virt: Remove deprecated virt-2.12 machine
> > > >     hw/arm/virt: Remove VirtMachineClass::no_highmem_ecam field
> > >
> > > Please ignore this (reviewed) series for now. I'll rebase it and
> > > repost after the 10.0 release.
> >
> > Why? IMHO it should be ok to include them now already. While Daniel's macro
> > only starts the automatic disablement for 10.1, it should be ok to remove
> > them now already according to our normal deprecation policy: The machines
> > have been marked as deprecated in the 9.1 release already (via commit
> > https://gitlab.com/qemu-project/qemu/-/commit/ce80c4fa6ff ), and thus they
> > have been deprecated since two releases already. So it should be fine to
> > remove them now, shouldn't it?
>
> No, because as of 9.1.0 we documented that machine types are under the
> new policy, and these were only deprecated in 9.1.0, hence the new policy
> applies to them.

Hm, I guess we could argue now about the wording (I don't see a spot in 
ce80c4fa6ff that says that this only happens starting with 10.1), but in the 
long run, it doesn't really matter much whether we remove these machines 
with 10.0 already or just with 10.1, so let's go with 10.1 instead.

 Thomas