Re: [PATCH-for-10.1 v2 06/13] hw/arm/virt: Remove deprecated virt-2.8 machine

[Richard Henderson]

On 1/16/25 06:59, Philippe Mathieu-Daudé wrote:
> This machine has been supported for a period of more than 6 years.
> According to our versioned machine support policy (see commit
> ce80c4fa6ff "docs: document special exception for machine type
> deprecation & removal") it can now be removed.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/arm/virt.c | 13 -------------
>   1 file changed, 13 deletions(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 06530a5dbf8..76d83cfdd3b 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -3572,16 +3572,3 @@ static void virt_machine_2_9_options(MachineClass *mc)
>       compat_props_add(mc->compat_props, hw_compat_2_9, hw_compat_2_9_len);
>   }
>   DEFINE_VIRT_MACHINE(2, 9)
> -
> -static void virt_machine_2_8_options(MachineClass *mc)
> -{
> -    VirtMachineClass *vmc = VIRT_MACHINE_CLASS(OBJECT_CLASS(mc));
> -
> -    virt_machine_2_9_options(mc);
> -    compat_props_add(mc->compat_props, hw_compat_2_8, hw_compat_2_8_len);
> -    /* For 2.8 and earlier we falsely claimed in the DT that
> -     * our timers were edge-triggered, not level-triggered.
> -     */
> -    vmc->claim_edge_triggered_timers = true;
> -}
> -DEFINE_VIRT_MACHINE(2, 8)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~