[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/3] pc-bios/s390-ccw: Fix problems related to network bootin
From: |
Eric Farman |
Subject: |
Re: [PATCH 0/3] pc-bios/s390-ccw: Fix problems related to network booting |
Date: |
Thu, 16 Jan 2025 10:33:17 -0500 |
User-agent: |
Evolution 3.54.2 (3.54.2-1.fc41) |
On Thu, 2025-01-16 at 12:58 +0100, Thomas Huth wrote:
> The boot can currently fail after the s390-ccw bios used a network
> device since we do not properly shut down the device afterwards, so
> that incoming network packets can corrupt the memory. We have to make
> sure to put the virtio-net device into a sane state again afterwards.
>
> The third patch is unrelated, but I spotted this rather cosmetic
> problem while working on the code in netmain.c, so I included it here,
> too.
>
> Thomas Huth (3):
> pc-bios/s390-ccw/virtio: Add a function to reset a virtio device
> pc-bios/s390-ccw: Fix boot problem with virtio-net devices
> pc-bios/s390-ccw/netmain: Fix error messages with regards to the TFTP
> server
Looks good to me; Thank you, Thomas! For the series:
Reviewed-by: Eric Farman <farman@linux.ibm.com>
>
> pc-bios/s390-ccw/virtio.h | 2 ++
> pc-bios/s390-ccw/netmain.c | 52 +++++++++++++++++++++--------------
> pc-bios/s390-ccw/virtio-net.c | 5 ++++
> pc-bios/s390-ccw/virtio.c | 7 ++++-
> 4 files changed, 44 insertions(+), 22 deletions(-)
>