[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH] hw/riscv/virt: Add serial alias in DTB
|
From: |
Vasilis Liaskovitis |
|
Subject: |
Re: [RFC PATCH] hw/riscv/virt: Add serial alias in DTB |
|
Date: |
Thu, 16 Jan 2025 14:38:21 +0100 |
On Thu, Jan 16, 2025 at 10:23:56AM +0100, Andrew Jones wrote:
>
> s/Fixes/Resolves/ (see docs/devel/submitting-a-patch.rst)
>
[..]
> > qemu_fdt_setprop_string(ms->fdt, "/chosen", "stdout-path", name);
> > + qemu_fdt_add_subnode(ms->fdt, "/aliases");
>
> create_fdt_uart() is called at machine-done time, so we should create the
> /aliases node in create_fdt() in case we ever have other uses for it.
thanks for the review, I am sending a v2 with the changes.
- Vasilis