qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 05/23] qapi/schema: add __repr__ to QAPIDoc.Section


From: Markus Armbruster
Subject: Re: [PATCH v2 05/23] qapi/schema: add __repr__ to QAPIDoc.Section
Date: Thu, 16 Jan 2025 12:50:51 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

John Snow <jsnow@redhat.com> writes:

> Makes debugging far more pleasant when you can just print(section) and
> get something reasonable to display.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  scripts/qapi/parser.py | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py
> index c3004aa70c6..cb259c42a6d 100644
> --- a/scripts/qapi/parser.py
> +++ b/scripts/qapi/parser.py
> @@ -673,6 +673,9 @@ def __init__(
>              # section text without tag
>              self.text = ''
>  
> +        def __repr__(self) -> str:
> +            return f"<QAPIDoc.Section tag={self.tag!r} text={self.text!r}>"

pylint points out

    scripts/qapi/parser.py:677:43: E1101: Instance of 'Section' has no 'tag' 
member (no-member)

Previous patch renamed it to @kind.

> +
>          def append_line(self, line: str) -> None:
>              self.text += line + '\n'




reply via email to

[Prev in Thread] Current Thread [Next in Thread]