[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/8] hw/intc/loongson_ipi: Remove property num_cpu from loongson_i
From: |
Bibo Mao |
Subject: |
[PULL 4/8] hw/intc/loongson_ipi: Remove property num_cpu from loongson_ipi_common |
Date: |
Thu, 16 Jan 2025 10:17:06 +0800 |
With mips64 loongson ipi, num_cpu property is used. With loongarch
ipi, num_cpu can be acquired from possible_cpu_arch_ids.
Here remove property num_cpu from loongson_ipi_common, and put it into
loongson and loongarch ipi separately.
Signed-off-by: Bibo Mao <maobibo@loongson.cn>
Reviewed-by: Bibo Mao <maobibo@loongson.cn>
---
hw/intc/loongarch_ipi.c | 6 ++++++
hw/intc/loongson_ipi.c | 6 ++++++
hw/intc/loongson_ipi_common.c | 6 ------
3 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/hw/intc/loongarch_ipi.c b/hw/intc/loongarch_ipi.c
index e6126e4fbc..9c7636c4d6 100644
--- a/hw/intc/loongarch_ipi.c
+++ b/hw/intc/loongarch_ipi.c
@@ -9,6 +9,7 @@
#include "hw/boards.h"
#include "qapi/error.h"
#include "hw/intc/loongarch_ipi.h"
+#include "hw/qdev-properties.h"
#include "target/loongarch/cpu.h"
static AddressSpace *get_iocsr_as(CPUState *cpu)
@@ -75,6 +76,10 @@ static void loongarch_ipi_realize(DeviceState *dev, Error
**errp)
}
}
+static const Property loongarch_ipi_properties[] = {
+ DEFINE_PROP_UINT32("num-cpu", LoongsonIPICommonState, num_cpu, 1),
+};
+
static void loongarch_ipi_class_init(ObjectClass *klass, void *data)
{
LoongsonIPICommonClass *licc = LOONGSON_IPI_COMMON_CLASS(klass);
@@ -83,6 +88,7 @@ static void loongarch_ipi_class_init(ObjectClass *klass, void
*data)
device_class_set_parent_realize(dc, loongarch_ipi_realize,
&lic->parent_realize);
+ device_class_set_props(dc, loongarch_ipi_properties);
licc->get_iocsr_as = get_iocsr_as;
licc->cpu_by_arch_id = loongarch_cpu_by_arch_id;
}
diff --git a/hw/intc/loongson_ipi.c b/hw/intc/loongson_ipi.c
index 1ed39b90ea..29e92d48fd 100644
--- a/hw/intc/loongson_ipi.c
+++ b/hw/intc/loongson_ipi.c
@@ -7,6 +7,7 @@
#include "qemu/osdep.h"
#include "hw/intc/loongson_ipi.h"
+#include "hw/qdev-properties.h"
#include "qapi/error.h"
#include "target/mips/cpu.h"
@@ -75,6 +76,10 @@ static void loongson_ipi_unrealize(DeviceState *dev)
k->parent_unrealize(dev);
}
+static const Property loongson_ipi_properties[] = {
+ DEFINE_PROP_UINT32("num-cpu", LoongsonIPICommonState, num_cpu, 1),
+};
+
static void loongson_ipi_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
@@ -85,6 +90,7 @@ static void loongson_ipi_class_init(ObjectClass *klass, void
*data)
&lic->parent_realize);
device_class_set_parent_unrealize(dc, loongson_ipi_unrealize,
&lic->parent_unrealize);
+ device_class_set_props(dc, loongson_ipi_properties);
licc->get_iocsr_as = get_iocsr_as;
licc->cpu_by_arch_id = cpu_by_arch_id;
}
diff --git a/hw/intc/loongson_ipi_common.c b/hw/intc/loongson_ipi_common.c
index 5d46679ea1..363cddc54c 100644
--- a/hw/intc/loongson_ipi_common.c
+++ b/hw/intc/loongson_ipi_common.c
@@ -9,7 +9,6 @@
#include "hw/sysbus.h"
#include "hw/intc/loongson_ipi_common.h"
#include "hw/irq.h"
-#include "hw/qdev-properties.h"
#include "qemu/log.h"
#include "migration/vmstate.h"
#include "trace.h"
@@ -301,10 +300,6 @@ static const VMStateDescription
vmstate_loongson_ipi_common = {
}
};
-static const Property ipi_common_properties[] = {
- DEFINE_PROP_UINT32("num-cpu", LoongsonIPICommonState, num_cpu, 1),
-};
-
static void loongson_ipi_common_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
@@ -314,7 +309,6 @@ static void loongson_ipi_common_class_init(ObjectClass
*klass, void *data)
&licc->parent_realize);
device_class_set_parent_unrealize(dc, loongson_ipi_common_unrealize,
&licc->parent_unrealize);
- device_class_set_props(dc, ipi_common_properties);
dc->vmsd = &vmstate_loongson_ipi_common;
}
--
2.43.5
- [PULL 0/8] loongarch-to-apply queue, Bibo Mao, 2025/01/15
- [PULL 3/8] hw/intc/loongson_ipi: Remove num_cpu from loongson_ipi_common, Bibo Mao, 2025/01/15
- [PULL 8/8] hw/intc/loongarch_ipi: Use alternative implemation for cpu_by_arch_id, Bibo Mao, 2025/01/15
- [PULL 6/8] hw/intc/loongarch_ipi: Remove property num-cpu, Bibo Mao, 2025/01/15
- [PULL 1/8] target/loongarch: Add page table walker support for debugger usage, Bibo Mao, 2025/01/15
- [PULL 4/8] hw/intc/loongson_ipi: Remove property num_cpu from loongson_ipi_common,
Bibo Mao <=
- [PULL 5/8] hw/intc/loongarch_ipi: Get cpu number from possible_cpu_arch_ids, Bibo Mao, 2025/01/15
- [PULL 2/8] hw/intc/loongarch_ipi: Implement realize interface, Bibo Mao, 2025/01/15
- [PULL 7/8] hw/intc/loongson_ipi: Add more input parameter for cpu_by_arch_id, Bibo Mao, 2025/01/15