Re: [PATCH v2 05/81] tcg: Add TCGOP_FLAGS

[Richard Henderson]

On 1/15/25 13:16, Philippe Mathieu-Daudé wrote:
> On 7/1/25 08:59, Richard Henderson wrote:
> > To be used by some integer operations instead of, or in addition to,
> > a trailing constant argument.
> >
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> >   include/tcg/tcg.h | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/include/tcg/tcg.h b/include/tcg/tcg.h
> > index 5d96cdfc30..e80b1f6efc 100644
> > --- a/include/tcg/tcg.h
> > +++ b/include/tcg/tcg.h
> > @@ -440,6 +440,7 @@ struct TCGOp {
> >   #define TCGOP_CALLO(X)    (X)->param2
> >   #define TCGOP_TYPE(X)     (X)->param1
> > +#define TCGOP_FLAGS(X)    (X)->param1
>
> I skipped this because there was some code smell around I
> couldn't figure. Hopefully a typo :)

Yes, a typo.  Thankfully this field isn't within these converted opcodes.


r~