[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 15/21] hw/block/fdc-isa: Remove 'fallback' property
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 15/21] hw/block/fdc-isa: Remove 'fallback' property |
Date: |
Thu, 16 Jan 2025 00:22:41 +0100 |
The "fallback" property was only used by the hw_compat_2_5[] array,
as 'fallback=144'. We removed all machines using that array, lets
remove ISA floppy drive 'fallback' property, manually setting the
default value in isabus_fdc_realize().
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/block/fdc-isa.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/block/fdc-isa.c b/hw/block/fdc-isa.c
index a10c24aab10..9e99a183c1d 100644
--- a/hw/block/fdc-isa.c
+++ b/hw/block/fdc-isa.c
@@ -112,6 +112,7 @@ static void isabus_fdc_realize(DeviceState *dev, Error
**errp)
}
qdev_set_legacy_instance_id(dev, isa->iobase, 2);
+ qdev_prop_set_enum(dev, "fallback", FLOPPY_DRIVE_TYPE_288);
fdctrl_realize_common(dev, fdctrl, &err);
if (err != NULL) {
@@ -293,9 +294,6 @@ static const Property isa_fdc_properties[] = {
DEFINE_PROP_SIGNED("fdtypeB", FDCtrlISABus, state.qdev_for_drives[1].type,
FLOPPY_DRIVE_TYPE_AUTO, qdev_prop_fdc_drive_type,
FloppyDriveType),
- DEFINE_PROP_SIGNED("fallback", FDCtrlISABus, state.fallback,
- FLOPPY_DRIVE_TYPE_288, qdev_prop_fdc_drive_type,
- FloppyDriveType),
};
static void isabus_fdc_class_init(ObjectClass *klass, void *data)
--
2.47.1
- Re: [PATCH 10/21] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_DISABLE_PCIE definition, (continued)
- [PATCH 11/21] hw/i386/pc: Remove deprecated pc-q35-2.5 and pc-i440fx-2.5 machines, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 12/21] hw/i386/x86: Remove X86MachineClass::save_tsc_khz field, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 13/21] hw/nvram/fw_cfg: Remove legacy FW_CFG_ORDER_OVERRIDE, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 14/21] hw/core/machine: Remove hw_compat_2_5[] array, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 15/21] hw/block/fdc-isa: Remove 'fallback' property,
Philippe Mathieu-Daudé <=
- [PATCH 16/21] hw/scsi/vmw_pvscsi: Remove PVSCSI_COMPAT_OLD_PCI_CONFIGURATION definition, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 17/21] hw/scsi/vmw_pvscsi: Remove PVSCSI_COMPAT_DISABLE_PCIE_BIT definition, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 18/21] hw/scsi/vmw_pvscsi: Convert DeviceRealize -> InstanceInit, Philippe Mathieu-Daudé, 2025/01/15