[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 05/21] target/i386/cpu: Remove X86CPU::check_cpuid field
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 05/21] target/i386/cpu: Remove X86CPU::check_cpuid field |
Date: |
Thu, 16 Jan 2025 00:22:31 +0100 |
The X86CPU::check_cpuid boolean was only set in the
pc_compat_2_4[] array, via the 'check=off' property.
We removed all machines using that array, lets remove
that CPU property and simplify x86_cpu_realizefn().
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/i386/cpu.h | 1 -
target/i386/cpu.c | 3 +--
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/target/i386/cpu.h b/target/i386/cpu.h
index dbd8f1ffc79..87917b7f895 100644
--- a/target/i386/cpu.h
+++ b/target/i386/cpu.h
@@ -2091,7 +2091,6 @@ struct ArchCPU {
uint8_t hyperv_ver_id_sb;
uint32_t hyperv_ver_id_sn;
- bool check_cpuid;
bool enforce_cpuid;
/*
* Force features to be enabled even if the host doesn't support them.
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 0b639848cd6..42227643126 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -7822,7 +7822,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error
**errp)
}
}
- if (x86_cpu_filter_features(cpu, cpu->check_cpuid || cpu->enforce_cpuid)) {
+ if (x86_cpu_filter_features(cpu, cpu->enforce_cpuid)) {
if (cpu->enforce_cpuid) {
error_setg(&local_err,
accel_uses_host_cpuid() ?
@@ -8491,7 +8491,6 @@ static const Property x86_cpu_properties[] = {
DEFINE_PROP_UINT8("hv-version-id-sbranch", X86CPU, hyperv_ver_id_sb, 0),
DEFINE_PROP_UINT32("hv-version-id-snumber", X86CPU, hyperv_ver_id_sn, 0),
- DEFINE_PROP_BOOL("check", X86CPU, check_cpuid, true),
DEFINE_PROP_BOOL("enforce", X86CPU, enforce_cpuid, false),
DEFINE_PROP_BOOL("x-force-features", X86CPU, force_features, false),
DEFINE_PROP_BOOL("kvm", X86CPU, expose_kvm, true),
--
2.47.1
- [PATCH 00/21] hw/i386/pc: Remove deprecated 2.4 and 2.5 PC machines, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 01/21] hw/i386/pc: Remove unused pc_compat_2_3 declarations, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 02/21] hw/i386/pc: Remove deprecated pc-q35-2.4 and pc-i440fx-2.4 machines, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 03/21] hw/i386/pc: Remove PCMachineClass::broken_reserved_end field, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 04/21] hw/i386/pc: Remove pc_compat_2_4[] array, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 05/21] target/i386/cpu: Remove X86CPU::check_cpuid field,
Philippe Mathieu-Daudé <=
- [PATCH 06/21] target/i386/cpu: Pass Error** to x86_cpu_filter_features(), Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 07/21] hw/core/machine: Remove hw_compat_2_4[] array, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 08/21] hw/net/e1000: Remove unused E1000_FLAG_MAC flag, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 09/21] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_MIGRATE_EXTRA definition, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 10/21] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_DISABLE_PCIE definition, Philippe Mathieu-Daudé, 2025/01/15