[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 07/13] hw/arm/virt: Remove VirtMachineClass::claim_edge_triggered
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 07/13] hw/arm/virt: Remove VirtMachineClass::claim_edge_triggered_timers field |
Date: |
Wed, 15 Jan 2025 18:10:03 +0100 |
The VirtMachineClass::claim_edge_triggered_timers field
was only used by virt-2.8 machine, which got removed.
Remove it and simplify fdt_add_timer_nodes() and build_gtdt().
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/hw/arm/virt.h | 1 -
hw/arm/virt-acpi-build.c | 5 +----
hw/arm/virt.c | 5 -----
3 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h
index 463ac09615e..9c531e28d04 100644
--- a/include/hw/arm/virt.h
+++ b/include/hw/arm/virt.h
@@ -118,7 +118,6 @@ typedef enum VirtGICType {
struct VirtMachineClass {
MachineClass parent;
bool no_tcg_its;
- bool claim_edge_triggered_timers;
bool smbios_old_sys_ver;
bool no_highmem_compact;
bool no_highmem_ecam;
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index ccecea9e09b..6e04fea165a 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -537,15 +537,12 @@ build_srat(GArray *table_data, BIOSLinker *linker,
VirtMachineState *vms)
static void
build_gtdt(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
{
- VirtMachineClass *vmc = VIRT_MACHINE_GET_CLASS(vms);
/*
* Table 5-117 Flag Definitions
* set only "Timer interrupt Mode" and assume "Timer Interrupt
* polarity" bit as '0: Interrupt is Active high'
*/
- uint32_t irqflags = vmc->claim_edge_triggered_timers ?
- 1 : /* Interrupt is Edge triggered */
- 0; /* Interrupt is Level triggered */
+ const uint32_t irqflags = 0; /* Interrupt is Level triggered */
AcpiTable table = { .sig = "GTDT", .rev = 3, .oem_id = vms->oem_id,
.oem_table_id = vms->oem_table_id };
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 4ec94190769..ec47ee4755a 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -361,14 +361,9 @@ static void fdt_add_timer_nodes(const VirtMachineState
*vms)
* the correct information.
*/
ARMCPU *armcpu;
- VirtMachineClass *vmc = VIRT_MACHINE_GET_CLASS(vms);
uint32_t irqflags = GIC_FDT_IRQ_FLAGS_LEVEL_HI;
MachineState *ms = MACHINE(vms);
- if (vmc->claim_edge_triggered_timers) {
- irqflags = GIC_FDT_IRQ_FLAGS_EDGE_LO_HI;
- }
-
if (vms->gic_version == VIRT_GIC_VERSION_2) {
irqflags = deposit32(irqflags, GIC_FDT_IRQ_PPI_CPU_START,
GIC_FDT_IRQ_PPI_CPU_WIDTH,
--
2.47.1
- Re: [PATCH 01/13] hw/arm/virt: Remove deprecated virt-2.6 machine, (continued)
- [PATCH 03/13] hw/arm/virt: Remove VirtMachineClass::disallow_affinity_adjustment, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 02/13] hw/arm/virt: Remove VirtMachineClass::no_pmu field, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 04/13] hw/arm/virt: Remove deprecated virt-2.7 machine, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 05/13] hw/arm/virt: Remove VirtMachineClass::no_its field, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 06/13] hw/arm/virt: Remove deprecated virt-2.8 machine, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 07/13] hw/arm/virt: Remove VirtMachineClass::claim_edge_triggered_timers field,
Philippe Mathieu-Daudé <=
- [PATCH 08/13] hw/arm/virt: Remove deprecated virt-2.9 machine, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 09/13] hw/arm/virt: Remove deprecated virt-2.10 machine, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 10/13] hw/arm/virt: Remove deprecated virt-2.11 machine, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 11/13] hw/arm/virt: Remove VirtMachineClass::smbios_old_sys_ver field, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 12/13] hw/arm/virt: Remove deprecated virt-2.12 machine, Philippe Mathieu-Daudé, 2025/01/15
- [PATCH 13/13] hw/arm/virt: Remove VirtMachineClass::no_highmem_ecam field, Philippe Mathieu-Daudé, 2025/01/15