Re: [PATCH] virtio-balloon-pci: Allow setting nvectors, so we can use MSI-X

[Reza Arbab]

On Wed, Jan 15, 2025 at 03:54:27AM -0500, Michael S. Tsirkin wrote:
> In file included from ../hw/virtio/virtio-balloon-pci.c:15:
> ../hw/virtio/virtio-balloon-pci.c: In function ‘virtio_balloon_pci_class_init’:
> ../include/qemu/osdep.h:261:35: error: call to ‘qemu_build_not_reached_always’ 
> declared with attribute error: code path is reachable
>  261 | #define qemu_build_not_reached()  qemu_build_not_reached_always()
>      |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../include/hw/qdev-core.h:956:13: note: in expansion of macro 
> ‘qemu_build_not_reached’
>  956 |             qemu_build_not_reached();                                   \
>      |             ^~~~~~~~~~~~~~~~~~~~~~
> ../hw/virtio/virtio-balloon-pci.c:69:5: note: in expansion of macro 
> ‘device_class_set_props’
>   69 |     device_class_set_props(dc, virtio_balloon_properties);
>      |     ^~~~~~~~~~~~~~~~~~~~~~

Ah, I need to declare virtio_balloon_properties as const.

--
Reza Arbab