Re: [PATCH v2 0/2] xen: error handling and FreeBSD compatibility fixes

[David Woodhouse]

On Wed, 2025-01-15 at 15:34 +0100, Roger Pau Monné wrote:
> On Fri, Jan 10, 2025 at 10:02:53AM +0000, David Woodhouse wrote:
> > On Fri, 2025-01-10 at 10:35 +0100, Roger Pau Monne wrote:
> > > Hello,
> > > 
> > > First patch from David introduces a new helper to fetch xenstore nodes,
> > > while second patch removes the usage of scanf related functions with the
> > > "%ms" format specifier, as it's not supported by the FreeBSD scanf libc
> > > implementation.
> > > 
> > > Thanks, Roger.
> > 
> > Thanks. I've got a handful of non-bugfix cleanups to use the new
> > xs_node_read in my tree at
> > https://git.infradead.org/users/dwmw2/qemu.git/shortlog/refs/heads/xs_node_read
> > 
> > David Woodhouse (4):
> >       hw/xen: Use xs_node_read() from xs_node_vscanf()
> >       hw/xen: Use xs_node_read() from xen_console_get_name()
> >       hw/xen: Use xs_node_read() from xen_netdev_get_name()
> >       hw/xen: Use xs_node_read() from xenstore_read_str() instead of 
> > open-coding it
> 
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks. I'll add that on each of the four.

> > I'm slightly dubious about the last one; xen_pvdev.c didn't previously
> > use anything from xen-bus-helper.c and even hardcodes zero for
> > XBT_NULL. And I look at the way it deliberately reallocates the string,
> > and wonder if we should be doing that in qemu_xen_xs_read() for the
> > true Xen case. And does it even matter anywhere except Windows?
> 
> I would take the opportunity to use XBT_NULL instead of 0 on
> xen_pvdev.c for the transaction.

Yeah, probably a separate patch.

smime.p7s
Description: S/MIME cryptographic signature