[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/8] hw/s390x/css: Remove the obsolete "css_migration_enabled" va
From: |
Thomas Huth |
Subject: |
[PATCH 2/8] hw/s390x/css: Remove the obsolete "css_migration_enabled" variable |
Date: |
Wed, 15 Jan 2025 08:38:13 +0100 |
Now that the s390-ccw-virtio-2.9 machine type has been removed, we
don't need the "css_migration_enabled" variable anymore and can remove
the related code.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
include/hw/s390x/css.h | 6 ------
hw/s390x/css.c | 31 +------------------------------
2 files changed, 1 insertion(+), 36 deletions(-)
diff --git a/include/hw/s390x/css.h b/include/hw/s390x/css.h
index cd97e2b707..dbf919bdd2 100644
--- a/include/hw/s390x/css.h
+++ b/include/hw/s390x/css.h
@@ -333,10 +333,4 @@ static inline int ccw_dstream_read_buf(CcwDataStream *cds,
void *buff, int len)
#define ccw_dstream_read(cds, v) ccw_dstream_read_buf((cds), &(v), sizeof(v))
#define ccw_dstream_write(cds, v) ccw_dstream_write_buf((cds), &(v), sizeof(v))
-/**
- * true if (vmstate based) migration of the channel subsystem
- * is enabled, false if it is disabled.
- */
-extern bool css_migration_enabled;
-
#endif
diff --git a/hw/s390x/css.c b/hw/s390x/css.c
index 4e27b2961b..d0680625ca 100644
--- a/hw/s390x/css.c
+++ b/hw/s390x/css.c
@@ -23,8 +23,6 @@
#include "hw/s390x/s390-virtio-ccw.h"
#include "hw/s390x/s390-ccw.h"
-bool css_migration_enabled = true;
-
typedef struct CrwContainer {
CRW crw;
QTAILQ_ENTRY(CrwContainer) sibling;
@@ -180,16 +178,10 @@ static const VMStateDescription vmstate_orb = {
}
};
-static bool vmstate_schdev_orb_needed(void *opaque)
-{
- return css_migration_enabled;
-}
-
static const VMStateDescription vmstate_schdev_orb = {
.name = "s390_subch_dev/orb",
.version_id = 1,
.minimum_version_id = 1,
- .needed = vmstate_schdev_orb_needed,
.fields = (const VMStateField[]) {
VMSTATE_STRUCT(orb, SubchDev, 1, vmstate_orb, ORB),
VMSTATE_END_OF_LIST()
@@ -390,33 +382,12 @@ static int subch_dev_post_load(void *opaque, int
version_id)
css_subch_assign(s->cssid, s->ssid, s->schid, s->devno, s);
}
- if (css_migration_enabled) {
- /* No compat voodoo to do ;) */
- return 0;
- }
- /*
- * Hack alert. If we don't migrate the channel subsystem status
- * we still need to find out if the guest enabled mss/mcss-e.
- * If the subchannel is enabled, it certainly was able to access it,
- * so adjust the max_ssid/max_cssid values for relevant ssid/cssid
- * values. This is not watertight, but better than nothing.
- */
- if (s->curr_status.pmcw.flags & PMCW_FLAGS_MASK_ENA) {
- if (s->ssid) {
- channel_subsys.max_ssid = MAX_SSID;
- }
- if (s->cssid != channel_subsys.default_cssid) {
- channel_subsys.max_cssid = MAX_CSSID;
- }
- }
return 0;
}
void css_register_vmstate(void)
{
- if (css_migration_enabled) {
- vmstate_register(NULL, 0, &vmstate_css, &channel_subsys);
- }
+ vmstate_register(NULL, 0, &vmstate_css, &channel_subsys);
}
IndAddr *get_indicator(hwaddr ind_addr, int len)
--
2.47.1
- [PATCH 0/8] s390x: Remove deprecated machine types v2.9 up to v2.12, Thomas Huth, 2025/01/15
- [PATCH 1/8] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.9 machine type, Thomas Huth, 2025/01/15
- [PATCH 2/8] hw/s390x/css: Remove the obsolete "css_migration_enabled" variable,
Thomas Huth <=
- [PATCH 3/8] hw/s390x/s390-stattrib: Remove the old migration_enabled flag, Thomas Huth, 2025/01/15
- [PATCH 4/8] hw/intc/s390_flic: Remove the obsolete migration_enabled flag, Thomas Huth, 2025/01/15
- [PATCH 5/8] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.10 and 2.11 machine types, Thomas Huth, 2025/01/15
- [PATCH 6/8] hw/s390x/event-facility: Remove the obsolete "allow_all_mask_sizes" code, Thomas Huth, 2025/01/15
- [PATCH 7/8] target/s390x/gen-features: Remove the v2.11 qemu CPU model, Thomas Huth, 2025/01/15
- [PATCH 8/8] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.12 machine type, Thomas Huth, 2025/01/15