Re: [PATCH 1/2] hw/riscv/riscv-iommu: Remove redundant variables

[Andrew Jones]

s/redundant/unused/ <<<$SUBJECT
s/variables/struct members/ <<<$SUBJECT

Both this and the previous patch should get some sort of commit message
explaining how the unused and redundant elements where found.

On Tue, Jan 14, 2025 at 05:36:45PM +0800, Jason Chien wrote:
> Signed-off-by: Jason Chien <jason.chien@sifive.com>
> ---
>  hw/riscv/riscv-iommu.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/hw/riscv/riscv-iommu.h b/hw/riscv/riscv-iommu.h
> index 9424989df4..fa8a50fa24 100644
> --- a/hw/riscv/riscv-iommu.h
> +++ b/hw/riscv/riscv-iommu.h
> @@ -58,11 +58,6 @@ struct RISCVIOMMUState {
>      /* interrupt notifier */
>      void (*notify)(RISCVIOMMUState *iommu, unsigned vector);
>  
> -    /* IOMMU State Machine */
> -    QemuThread core_proc; /* Background processing thread */
> -    QemuCond core_cond;   /* Background processing wake up signal */
> -    unsigned core_exec;   /* Processing thread execution actions */
> -
>      /* IOMMU target address space */
>      AddressSpace *target_as;
>      MemoryRegion *target_mr;
> -- 
> 2.43.2
> 
>

Otherwise,

Reviewed-by: Andrew Jones <ajones@ventanamicro.com>