Re: [PATCH] migration: fix -Werror=maybe-uninitialized

[Marc-André Lureau]

Hi

On Tue, Jan 14, 2025 at 6:42 PM Fabiano Rosas <farosas@suse.de> wrote:
>
> marcandre.lureau@redhat.com writes:
>
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > ../migration/savevm.c: In function 
> > ‘qemu_savevm_state_complete_precopy_non_iterable’:
> > ../migration/savevm.c:1560:20: error: ‘ret’ may be used uninitialized 
> > [-Werror=maybe-uninitialized]
> >  1560 |             return ret;
> >       |                    ^~~
>
> Weird that this didn't show up anywhere.

I have a build setup with '--enable-debug' '--enable-asan'
'-Doptimization=g' '-Ddebug=true' for development.

Unfortunately, devs and CI don't seem to run with those flags, we
should probably add it back to CI (apparently partially dropped with
commit cb771ac1). There are regressions to clean up nowadays. Help
welcome!

>
> >
> > Cc: Peter Xu <peterx@redhat.com>
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Reviewed-by: Fabiano Rosas <farosas@suse.de>
>
> > ---
> >  migration/savevm.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/migration/savevm.c b/migration/savevm.c
> > index c929da1ca5..6e56d4cf1d 100644
> > --- a/migration/savevm.c
> > +++ b/migration/savevm.c
> > @@ -1557,7 +1557,7 @@ int 
> > qemu_savevm_state_complete_precopy_non_iterable(QEMUFile *f,
> >              migrate_set_error(ms, local_err);
> >              error_report_err(local_err);
> >              qemu_file_set_error(f, -EFAULT);
> > -            return ret;
> > +            return -1;
> >          }
> >      }
> >      if (!in_postcopy) {
>