Re: [PATCH v4 4/5] virtio-gpu: Support asynchronous fencing

[Dmitry Osipenko]

On 1/14/25 01:00, Alex Bennée wrote:
...
> This needs to be gated on support from virglrenderer:
> 
>   /display/virtio-gpu-virgl.c
>   ../../hw/display/virtio-gpu-virgl.c: In function 
> ‘virtio_gpu_virgl_process_cmd’:
>   ../../hw/display/virtio-gpu-virgl.c:980:15: error: implicit declaration of 
> function ‘virgl_renderer_context_create_fence’; did you mean 
> ‘virgl_renderer_context_create’? [-Werror=implicit-function-declaration]
>     980 |         ret = 
> virgl_renderer_context_create_fence(cmd->cmd_hdr.ctx_id, flags,
>         |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>         |               virgl_renderer_context_create
>   ../../hw/display/virtio-gpu-virgl.c:980:15: error: nested extern 
> declaration of ‘virgl_renderer_context_create_fence’ [-Werror=nested-externs]
>   ../../hw/display/virtio-gpu-virgl.c: At top level:
>   ../../hw/display/virtio-gpu-virgl.c:1088:13: error: 
> ‘virgl_write_context_fence’ defined but not used [-Werror=unused-function]
>    1088 | static void virgl_write_context_fence(void *opaque, uint32_t ctx_id,
>         |             ^~~~~~~~~~~~~~~~~~~~~~~~~
>   ../../hw/display/virtio-gpu-virgl.c:1002:13: error: 
> ‘virtio_gpu_virgl_async_fence_bh’ defined but not used 
> [-Werror=unused-function]
>    1002 | static void virtio_gpu_virgl_async_fence_bh(void *opaque)
>         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   cc1: all warnings being treated as errors

Good catch, will address in v5. Thanks!

-- 
Best regards,
Dmitry