qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] Add a b4 configuration file


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2] Add a b4 configuration file
Date: Mon, 13 Jan 2025 16:55:11 +0100
User-agent: Mozilla Thunderbird

On 13/1/25 07:53, Markus Armbruster wrote:
Philippe Mathieu-Daudé <philmd@linaro.org> writes:

On 2/1/25 23:53, Jiaxun Yang wrote:
b4 [1] is a convenient tool to manage patch series with mailing list
working flow.
Add a project default config file to match QEMU's mailing list conventions
as well as adopting differences on scripting.
Examples of b4:
```
$ b4 prep --check
Checking patches using:
    scripts/checkpatch.pl -q --terse --no-summary --mailback -
---
Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
Changes in v2:
- Add lore masks (philmd) from:
    https://lore.kernel.org/qemu-devel/20241224135054.10243-1-philmd@linaro.org/
- Link to v1: 
https://lore.kernel.org/r/20241222-b4-config-v1-1-b3667beb30a4@flygoat.com
---
● cc5a4c890fed: Add a b4 configuration file
    ● checkpatch.pl: 27: WARNING: added, moved or deleted file(s), does 
MAINTAINERS need updating?
---
Success: 0, Warning: 1, Error: 0
```
```
$ b4 prep -c
Will collect To: addresses using echo
Will collect Cc: addresses using get_maintainer.pl
Collecting To/Cc addresses
      + To: qemu-devel@nongnu.org
---
You can trim/expand this list with: b4 prep --edit-cover
Invoking git-filter-repo to update the cover letter.
New history written in 0.02 seconds...
Completely finished after 0.06 seconds
```
[1]: https://b4.docs.kernel.org/
Co-developed-by: Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
   .b4-config | 14 ++++++++++++++
   1 file changed, 14 insertions(+)

Squashing in order to avoid checkpatch.pl error:

-- >8 --
diff --git a/MAINTAINERS b/MAINTAINERS
index ec898a3cbc6..0c71eb3f925 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4310,3 +4310,9 @@ Machine development tool
  M: Maksim Davydov <davydov-max@yandex-team.ru>
  S: Supported
  F: scripts/compare-machine-types.py
+
+b4 tool configuration

Start the title with a capital letter, please.

+M: Jiaxun Yang <jiaxun.yang@flygoat.com>
+M: Philippe Mathieu-Daudé <philmd@linaro.org>
+S: Odd Fixes
+F: .b4-config

The scope of this entry is less than clear.  What kind of tools?

It's not our own tooling (scripts/...).  Perhaps it's tools used by
enough developers to warrant committing common configuration to Git.  We
have such configuration files already, not covered by MAINTAINERS, e.g.:

     .dir-locals.el
     .editorconfig
     .exrc
     .gdbinit
     .gitpublish
     .pylintrc

The path of least resistance is to add .b4-config the same way.

If we decide we want a new entry in MAINTAINERS, its scope should be
reasonably clear, and we should add existing files, if any, to it.

OK, then I'll just ignore ./checkpatch.pl warning for this patch.

Thanks,

Phil.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]