Re: [PATCH 0/3] bugfixes for migration using compression methods

[Michael Tokarev]

18.12.2024 12:14, Yuan Liu wrote:
> This set of patches is used to fix the bugs of incorrect migration
> memory data when compression is enabled.
>
> The method to reproduce this bug is as follows
> 1. Run "stress-ng --class memory --all 1" in the source side, the
> stress-ng tool comes from https://github.com/ColinIanKing/stress-ng.git
>
> 2. Enable the multifd compression methods and start migration
>     e.g. migrate_set_parameter multifd-compression qpl
>
> 3. The guest kernel will crash automatically or crash at shutdown after
>     the migration is complete
>
> The root cause of the bugs and the solutions are described in detail in
> the patch.
>
> My verification method as follows
> 1. Start the VM and run the stess-ng test command on the source side.
> 2. Start the VM with "-S" parameter on the target side, it is
>     used to pause the vCPUs after migration.
> 3. After the migration is successful, use the dump-guest-memory command
>     to export the memory data of the source and target VMs respectively.
> 4. Use "cmp -l source_memory target_memory" to verify memory data.
>
> Yuan Liu (3):
>    multifd: bugfix for migration using compression methods
>    multifd: bugfix for incorrect migration data with QPL compression
>    multifd: bugfix for incorrect migration data with qatzip compression

Should just the first patch be applied to qemu-stable branches, or all 3?
The first one has been Cc'd qemu-stable, but the other two hasn't?

Thanks,

/mjt