Re: [PULL v2 0/6] Linux user fix gupnp patches

[Stefan Hajnoczi]

On Wed, 8 Jan 2025 at 17:04, <deller@kernel.org> wrote:
>
> From: Helge Deller <deller@gmx.de>
>
> The following changes since commit 791e3837c1105aec4e328674aad32e34056957e2:
>
>   Merge tag 'net-pull-request' of https://github.com/jasowang/qemu into 
> staging (2024-11-25 10:44:11 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/hdeller/qemu-hppa.git 
> tags/linux-user-fix-gupnp-pull-request
>
> for you to fetch changes up to 526635dc5edf989781219c1ee7d50846c0555a46:
>
>   linux-user: netlink: Add missing QEMU_IFLA entries (2024-12-27 21:30:27 
> +0100)
>
> ----------------------------------------------------------------
> linux-user: Add support for various missing netlink sockopt entries
>
> This patchset adds various missing sockopt calls, so that qemu linux-user
> is able to successfully build the debian gupnp package in a chroot.
>
> Tested with a 32-bit big-endian hppa linux-user chroot running on a phyiscal
> x86-64 little-endian host.
>
> This fixes debian's bug report:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1044651
>
> Signed-off-by: Helge Deller <deller@gmx.de>
>
> Stefan, please merge it now in mainline (unless Laurent
> finally answers differently). It just adds until-now unsupporzted
> functionality, so nothing existing can break.
>
> ----------------------------------------------------------------
>
> Helge Deller (6):
>   linux-user: netlink: Add missing IFA_PROTO to
>     host_to_target_data_addr_rtattr()
>   linux-user: Use unique error messages for cmsg parsing
>   linux-user: netlink: Add IP_PKTINFO cmsg parsing
>   linux-user: netlink: Add emulation of IP_MULTICAST_IF
>   linux-user: netlink: add netlink neighbour emulation
>   linux-user: netlink: Add missing QEMU_IFLA entries
>
>  linux-user/fd-trans.c | 137 +++++++++++++++++++++++++++++++++++++++++-
>  linux-user/syscall.c  |  29 +++++++--
>  2 files changed, 161 insertions(+), 5 deletions(-)

Hi Helge,
Please take a look at this CI job failure and send a v3:
https://gitlab.com/qemu-project/qemu/-/jobs/8820703947

FAILED: libqemu-aarch64-linux-user.a.p/linux-user_fd-trans.c.o
cc -Ilibqemu-aarch64-linux-user.a.p -I. -I.. -Itarget/arm
-I../target/arm -I../common-user/host/aarch64
-I../linux-user/include/host/aarch64 -I../linux-user/include
-Ilinux-user -I../linux-user -Ilinux-user/aarch64
-I../linux-user/aarch64 -Iqapi -Itrace -Iui/shader
-I/usr/include/capstone -I/usr/include/glib-2.0
-I/usr/lib/aarch64-linux-gnu/glib-2.0/include -fdiagnostics-color=auto
-Wall -Winvalid-pch -Werror -std=gnu11 -O0 -g -fstack-protector-strong
-Wempty-body -Wendif-labels -Wexpansion-to-defined -Wformat-security
-Wformat-y2k -Wignored-qualifiers -Wimplicit-fallthrough=2 -Winit-self
-Wmissing-format-attribute -Wmissing-prototypes -Wnested-externs
-Wold-style-declaration -Wold-style-definition -Wredundant-decls
-Wshadow=local -Wstrict-prototypes -Wtype-limits -Wundef -Wvla
-Wwrite-strings -Wno-missing-include-dirs -Wno-psabi
-Wno-shift-negative-value -isystem
/home/gitlab-runner/builds/E8PpwMky/0/qemu-project/qemu/linux-headers
-isystem linux-headers -iquote . -iquote
/home/gitlab-runner/builds/E8PpwMky/0/qemu-project/qemu -iquote
/home/gitlab-runner/builds/E8PpwMky/0/qemu-project/qemu/include
-iquote 
/home/gitlab-runner/builds/E8PpwMky/0/qemu-project/qemu/host/include/aarch64
-iquote 
/home/gitlab-runner/builds/E8PpwMky/0/qemu-project/qemu/host/include/generic
-iquote /home/gitlab-runner/builds/E8PpwMky/0/qemu-project/qemu/tcg/aarch64
-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-fno-strict-aliasing -fno-common -fwrapv -fno-pie -no-pie
-fzero-call-used-regs=used-gpr -isystem../linux-headers
-isystemlinux-headers -DCOMPILING_PER_TARGET
'-DCONFIG_TARGET="aarch64-linux-user-config-target.h"' -MD -MQ
libqemu-aarch64-linux-user.a.p/linux-user_fd-trans.c.o -MF
libqemu-aarch64-linux-user.a.p/linux-user_fd-trans.c.o.d -o
libqemu-aarch64-linux-user.a.p/linux-user_fd-trans.c.o -c
../linux-user/fd-trans.c
../linux-user/fd-trans.c: In function ‘host_to_target_data_addr_rtattr’:
../linux-user/fd-trans.c:1181:10: error: ‘IFA_PROTO’ undeclared (first
use in this function); did you mean ‘IFA_RTA’?
1181 | case IFA_PROTO:
| ^~~~~~~~~
| IFA_RTA

Thanks,
Stefan