Re: macaddr: ignore the checking from index to 0xFF

[Peter Maydell]

On Tue, 24 Dec 2024 at 03:27, Liu Jaloo <liu.jaloo@gmail.com> wrote:
>
> bash-5.1$ git diff net/net.c
> diff --git a/net/net.c b/net/net.c
> index c1bb19a523..af68029428 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -173,6 +173,7 @@ static void qemu_macaddr_set_used(MACAddr *macaddr)
>      for (index = 0x56; index < 0xFF; index++) {
>          if (macaddr->a[5] == index) {
>              mac_table[index]++;
> +           return;
>          }
>      }
>  }
> @@ -188,6 +189,7 @@ static void qemu_macaddr_set_free(MACAddr *macaddr)
>      for (index = 0x56; index < 0xFF; index++) {
>          if (macaddr->a[5] == index) {
>              mac_table[index]--;
> +           return;
>          }
>      }
>  }

Hi; thanks for this patch. Unfortunately we can't accept it
without a Signed-off-by: line from you (which tells us that you're
OK for it to be contributed to QEMU under our usual license:
for more details see:
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#patch-emails-must-include-a-signed-off-by-line

Could you also provide a commit message explaining the reason
for the change?

(The code changes themselves seem sensible; I would use "break" rather
than "return", personally, but the effect is the same.)

thanks
-- PMM