[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] xen: do not use '%ms' scanf specifier
|
From: |
David Woodhouse |
|
Subject: |
Re: [PATCH v2 2/2] xen: do not use '%ms' scanf specifier |
|
Date: |
Fri, 10 Jan 2025 09:55:57 +0000 |
|
User-agent: |
Evolution 3.52.3-0ubuntu1 |
On Fri, 2025-01-10 at 10:35 +0100, Roger Pau Monne wrote:
> The 'm' parameter used to request auto-allocation of the destination variable
> is not supported on FreeBSD, and as such leads to failures to parse.
>
> What's more, the current usage of '%ms' with xs_node_scanf() is pointless, as
> it just leads to a double allocation of the same string. Instead use
> xs_node_read() to read the whole xenstore node.
>
> Fixes: a783f8ad4ec9 ('xen: add a mechanism to automatically create
> XenDevice-s...')
> Fixes: 9b7737469080 ('hw/xen: update Xen console to XenDevice model')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
Thanks.
smime.p7s
Description: S/MIME cryptographic signature
- [PATCH v2 0/2] xen: error handling and FreeBSD compatibility fixes, Roger Pau Monne, 2025/01/10
- [PATCH v2 1/2] hw/xen: Add xs_node_read() helper function, Roger Pau Monne, 2025/01/10
- [PATCH v2 2/2] xen: do not use '%ms' scanf specifier, Roger Pau Monne, 2025/01/10
- Re: [PATCH v2 0/2] xen: error handling and FreeBSD compatibility fixes, David Woodhouse, 2025/01/10
- [PATCH 4/4] hw/xen: Use xs_node_read() from xenstore_read_str() instead of open-coding it, David Woodhouse, 2025/01/10
- Re: [PATCH 4/4] hw/xen: Use xs_node_read() from xenstore_read_str() instead of open-coding it, Anthony PERARD, 2025/01/15