Re: [PATCH 09/23] qapi/source: allow multi-line QAPISourceInfo advancing

[Markus Armbruster]

John Snow <jsnow@redhat.com> writes:

> On Thu, Jan 9, 2025, 3:00 AM Markus Armbruster <armbru@redhat.com> wrote:
>
>> John Snow <jsnow@redhat.com> writes:
[...]
>> > Modifying freeform syntax to be purely rST that isn't modified or rewritten
>> > at all has benefits:
>> >
>> > - No need to mangle or multiplex source line source information
>> > - Less code
>> > - More straightforward
>> >
>> > I'm quite happy to do it later, is there some kind of "ticket" system you'd
>> > tolerate using for tracking nits for cleanup? I *will* forget if we don't
>> > listify and track them, I'm sorry (but wise enough) to admit. I just don't
>> > want to get sidetracked on little side-quests right now. (Quite prone to
>> > this...)
>>
>> TODO comment in code this would obviously kill?  Not exactly a ticket
>> system...
>>
>> scripts/qapi/TODO?  Still not a ticket system...
>>
>
> If a TODO is fine (and you don't mind pinging me in the future), then the
> comment I left in the visit_freeform() function (it's in another patch)
> explaining that the custom parser can be dropped after we sunset the old
> qapidoc is likely sufficient if I just add a "TODO".
>
> Sound good?

Yes.

[...]