Re: [PATCH v4 0/4] virtio: Convert feature properties to OnOffAuto

[Akihiko Odaki]

On 2025/01/09 21:53, Markus Armbruster wrote:
> Akihiko Odaki <akihiko.odaki@daynix.com> writes:
>
> > This series was spun off from:
> > "[PATCH 0/3] virtio-net: Convert feature properties to OnOffAuto"
> > (https://patchew.org/QEMU/20240714-auto-v3-0-e27401aabab3@daynix.com/)
> >
> > Some features are not always available with vhost. Legacy features are
> > not available with vp_vdpa in particular. virtio devices used to disable
> > them when not available even if the corresponding properties were
> > explicitly set to "on".
> >
> > QEMU already has OnOffAuto type, which includes the "auto" value to let
> > it automatically decide the effective value. Convert feature properties
> > to OnOffAuto and set them "auto" by default to utilize it. This allows
> > QEMU to report an error if they are set "on" and the corresponding
> > features are not available.
> >
> > Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
>
> How is this related to "[PATCH v2 0/4] hw/pci: Convert rom_bar into
> OnOffAuto"?
> https://lore.kernel.org/all/20240714-rombar-v2-0-af1504ef55de@daynix.com/
>

They are orthogonal. "[PATCH v2 0/4] hw/pci: Convert rom_bar into
OnOffAuto" was also abandoned in favor of "[PATCH v19 13/14] hw/pci: Use 
-1 as the default value for rombar".
20250109-reuse-v19-13-f541e82ca5f7@daynix.com">https://lore.kernel.org/r/20250109-reuse-v19-13-f541e82ca5f7@daynix.com