Re: [PATCH 10/22] system: propagate Error to gdbserver_start (and other device setups)

[Philippe Mathieu-Daudé]

On 9/1/25 20:45, Alex Bennée wrote:
> Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:
>
> > On 1/9/25 09:06, Alex Bennée wrote:
> > > This started as a clean-up to properly pass a Error handler to the
> > > gdbserver_start so we could do the right thing for command line and
> > > HMP invocations.
> > > Now that we have cleaned up foreach_device_config_or_exit() in
> > > earlier
> > > patches we can further simplify by it by passing &error_fatal instead
> > > of checking the return value. Having a return value is still useful
> > > for HMP though so tweak the return to use a simple bool instead.
> > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> > > Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>
> >
> > <snip>
> >
> > > -static int gdbserver_open_port(int port)
> > > +static int gdbserver_open_port(int port, Error **errp)
> >
> > Did you mean:
> > static bool gdbserver_open_port...?
>
> yes, yes I did. Will fix.

This is returning a socket file descriptor, why bool?

> > With that,
> > Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>