Re: [PATCH 12/14] hw/i2c/imx_i2c: Convert DPRINTF() to trace events

[Philippe Mathieu-Daudé]

On 9/1/25 12:56, Philippe Mathieu-Daudé wrote:
> On 9/1/25 12:43, Philippe Mathieu-Daudé wrote:
> > On 8/1/25 10:25, Bernhard Beschow wrote:
> > > Also print the MMIO address when tracing. This allows to 
> > > distinguishing the
> > > many instances a typical i.MX SoC has.
>
> I'm not a fan of using peripheral address access, because it
> can change i.e. when a vCPU is accessing it from secure or
> non-secure mode.
>
> I'd rather use an 'id', a 'name' or even the QOM (canonical?)
> path.
>
> Maybe we should directly cache that as Device::qom_path, so
> all devices can use it for tracing, and we don't need to set
> an id/name property when creating the device...

We already have that, it is Device::canonical_path :)

> > > Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> > > ---
> > >   hw/i2c/imx_i2c.c    | 21 +++++----------------
> > >   hw/i2c/trace-events |  5 +++++
> > >   2 files changed, 10 insertions(+), 16 deletions(-)
> >
> > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>