Re: [PATCH v2 2/3] Add plugin API functions for register R/W, hwaddr R/W, vaddr W

[Alex Bennée]

Rowan Hart <rowanbhart@gmail.com> writes:

> From: novafacing <rowanbhart@gmail.com>
>
> ---
>  include/qemu/qemu-plugin.h | 116 +++++++++++++++++++++++++++++++++----
>  plugins/api.c              |  66 ++++++++++++++++++++-
>  2 files changed, 168 insertions(+), 14 deletions(-)
>
> diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
> index 0fba36ae02..b812593e7f 100644
> --- a/include/qemu/qemu-plugin.h
> +++ b/include/qemu/qemu-plugin.h
> @@ -65,11 +65,18 @@ typedef uint64_t qemu_plugin_id_t;
>   *
>   * version 4:
>   * - added qemu_plugin_read_memory_vaddr
> + *
> + * version 5:
> + * - added qemu_plugin_write_memory_vaddr
> + * - added qemu_plugin_read_memory_hwaddr
> + * - added qemu_plugin_write_memory_hwaddr
> + * - added qemu_plugin_write_register
> + *
>   */

In the next version please split up the API additions to make it easier
to review. For now w.r.t. hwaddr I refer to:

  Subject: Re: [PATCH 1/1] plugins: add API to read guest CPU memory from hwaddr
  In-Reply-To: <20240828063224.291503-2-rowanbhart@gmail.com> (Rowan Hart's 
message of "Tue, 27 Aug 2024 23:32:24 -0700")
  References: <20240828063224.291503-1-rowanbhart@gmail.com> 
<20240828063224.291503-2-rowanbhart@gmail.com>
  Date: Thu, 09 Jan 2025 11:38:48 +0000
  Message-ID: <877c749pyv.fsf@draig.linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro