Re: [PATCH v4 1/6] tests: Add functional tests for HPPA machines

[Helge Deller]

On 12/31/24 20:06, Philippe Mathieu-Daudé wrote:
> Add quick firmware boot tests (less than 1sec) for the
> B160L (32-bit) and C3700 (64-bit) HPPA machines:
>
>    $ make check-functional-hppa
>    1/4 qemu:func-quick+func-hppa / func-hppa-empty_cpu_model OK 0.13s 1 
> subtests passed
>    2/4 qemu:func-quick+func-hppa / func-hppa-version         OK 0.14s 1 
> subtests passed
>    3/4 qemu:func-quick+func-hppa / func-hppa-info_usernet    OK 0.22s 1 
> subtests passed
>    4/4 qemu:func-quick+func-hppa / func-hppa-hppa_seabios    OK 0.22s 2 
> subtests passed
>
> Suggested-by: Helge Deller <deller@gmx.de>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Helge Deller <deller@gmx.de>

> ---
>   MAINTAINERS                           |  1 +
>   tests/functional/meson.build          |  4 +++
>   tests/functional/test_hppa_seabios.py | 35 +++++++++++++++++++++++++++
>   3 files changed, 40 insertions(+)
>   create mode 100755 tests/functional/test_hppa_seabios.py
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 38a290e9c2c..17c720dd2b9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1201,6 +1201,7 @@ F: include/hw/pci-host/astro.h
>   F: include/hw/pci-host/dino.h
>   F: pc-bios/hppa-firmware.img
>   F: roms/seabios-hppa/
> +F: tests/functional/test_hppa_seabios.py
>
>   LoongArch Machines
>   ------------------
> diff --git a/tests/functional/meson.build b/tests/functional/meson.build
> index 24f7f8f2f1c..71810a3aa82 100644
> --- a/tests/functional/meson.build
> +++ b/tests/functional/meson.build
> @@ -104,6 +104,10 @@ tests_avr_system_thorough = [
>     'avr_mega2560',
>   ]
>
> +tests_hppa_system_quick = [
> +  'hppa_seabios',
> +]
> +
>   tests_i386_system_thorough = [
>     'i386_tuxrun',
>   ]
> diff --git a/tests/functional/test_hppa_seabios.py 
> b/tests/functional/test_hppa_seabios.py
> new file mode 100755
> index 00000000000..a44d1a3eebe
> --- /dev/null
> +++ b/tests/functional/test_hppa_seabios.py
> @@ -0,0 +1,35 @@
> +#!/usr/bin/env python3
> +#
> +# SeaBIOS boot test for HPPA machines
> +#
> +# Copyright (c) 2024 Linaro, Ltd
> +#
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +
> +from qemu_test import QemuSystemTest
> +from qemu_test import wait_for_console_pattern
> +
> +class HppaSeabios(QemuSystemTest):
> +
> +    timeout = 5
> +    MACH_BITS = {'B160L': 32, 'C3700': 64}
> +
> +    def boot_seabios(self):
> +        mach = self.machine
> +        bits = self.MACH_BITS[mach]
> +        self.vm.set_console()
> +        self.vm.launch()
> +        self.machine
> +        wait_for_console_pattern(self, f'SeaBIOS PA-RISC {bits}-bit Firmware')
> +        wait_for_console_pattern(self, f'Emulated machine:     HP {mach} 
> ({bits}-bit')
> +
> +    def test_hppa_32(self):
> +        self.set_machine('B160L')
> +        self.boot_seabios()
> +
> +    def test_hppa_64(self):
> +        self.set_machine('C3700')
> +        self.boot_seabios()
> +
> +if __name__ == '__main__':
> +    QemuSystemTest.main()