Re: [PATCH] hw/sd/sdcard: Remove sd_set_cb()

[Peter Maydell]

On Wed, 8 Jan 2025 at 10:47, Cédric Le Goater <clg@redhat.com> wrote:
>
> On 1/8/25 11:43, Philippe Mathieu-Daudé wrote:
> > On 8/1/25 11:02, Cédric Le Goater wrote:
> >> Last user of sd_set_cb() was removed in commit ce5dd27534b0 ("hw/sd:
> >> Remove omap2_mmc device").
> >
> > https://lore.kernel.org/qemu-devel/20240903200446.25921-2-philmd@linaro.org/
> > ;)
> >
>
> Ah ! good. I was wondering what to do of the '*_cb' IRQs and
> 'me_no_qdev_me_kill_mammoth_with_rocks' too. You dropped them
> all.

Yeah, but we still have a caller of sd_init()...

I was vaguely planning to do the qdev conversion of
omap_mmc (should be straightforward since we now have a
functional test that exercises sd card boot so we can
be confident we don't break it in the process), which would
then let us drop sd_init() entirely. I don't think this is
much work, but I don't expect to get to it this month because
I have a chunk of higher-priority stuff I need to focus on
first.

thanks
-- PMM