[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] hw/i386/pc: Fix level interrupt sharing for Xen event cha
From: |
David Woodhouse |
Subject: |
Re: [PATCH v2] hw/i386/pc: Fix level interrupt sharing for Xen event channel GSI |
Date: |
Tue, 07 Jan 2025 16:58:26 +0000 |
User-agent: |
Evolution 3.52.3-0ubuntu1 |
On Tue, 2025-01-07 at 16:38 +0000, Paul Durrant wrote:
>
> > +#ifdef CONFIG_XEN_EMU
> > + /*
> > + * Xen delivers the GSI to the Legacy PIC (not that Legacy PIC
> > + * routing actually works properly under Xen). And then to
> > + * *either* the PIRQ handling or the I/OAPIC depending on
> > + * whether the former wants it.
> > + *
> > + * Additionally, this hook allows the Xen event channel GSI to
> > + * work around QEMU's lack of support for shared level interrupts,
> > + * by keeping track of the externally driven state of the pin and
> > + * implementing a logical OR with the state of the evtchn GSI.
> > + */
>
> Looks like something went wrong with the indent here.
Fixed the indentation for the comment to 4 spaces in my tree; thanks.
smime.p7s
Description: S/MIME cryptographic signature