[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/functional/test_x86_64_hotplug_cpu: Fix race condition
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH] tests/functional/test_x86_64_hotplug_cpu: Fix race condition during unplug |
Date: |
Tue, 7 Jan 2025 07:50:47 -0500 |
On Tue, 7 Jan 2025 at 06:52, Thomas Huth <thuth@redhat.com> wrote:
>
> When unplugging the CPU, the test tries to check for a successful
> unplug by changing to the /sys/devices/system/cpu/cpu1 directory
> to see whether that fails. However, the "cd" could be faster than
> the unplug operation in the kernel, so there is a race condition
> and the test sometimes fails here.
> Fix it by trying to change the directory in a loop until the the
> CPU has really been unplugged.
>
> Reported-by: Stefan Hajnoczi <stefanha@gmail.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/functional/test_x86_64_hotplug_cpu.py | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Thanks for fixing this! I'll keep an eye on the CI job status after
merging your next pull request.
Stefan