qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 21/23] qapi/machine: Replace TARGET_LOONGARCH64 with TARGE


From: Markus Armbruster
Subject: Re: [PATCH v2 21/23] qapi/machine: Replace TARGET_LOONGARCH64 with TARGET_LOONGARCH
Date: Tue, 07 Jan 2025 12:06:52 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

Jiaxun Yang <jiaxun.yang@flygoat.com> writes:

> All TARGET_LOONGARCH64 qapis are also available for LoongArch32 as we
> are reusing the same CPU backend implemenation.

As far as I can tell this makes query-cpu-model-expansion and
query-cpu-definitions in the LoongArch32 build, too.

> Use TARGET_LOONGARCH to identify LoongArch.

Suggest to be more explicit. e.g. like this:

  The QAPI commands specific to target loongarch64 are wanted for
  loongarch32, too.  These are query-cpu-model-expansion and
  query-cpu-definitions.  They just work, since the two use the same CPU
  implementation.

  Replace TARGET_LOONGARCH64 by TARGET_LOONGARCH.

> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

Preferably with an improved commit message
Acked-by: Markus Armbruster <armbru@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]