Re: [PATCH v2 0/2] qtest: Remove uses of 'first_cpu'

[Thomas Huth]

On 04/01/2025 00.48, Philippe Mathieu-Daudé wrote:
> On 3/1/25 13:26, Fabiano Rosas wrote:
> > Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> >
> > > Hi Fabiano,
> > >
> > > On 12/12/24 00:37, Philippe Mathieu-Daudé wrote:
> > > > Replace first_cpu->as by address_space_memory.
> > > >
> > > > Philippe Mathieu-Daudé (2):
> > > >     system/qtest: Remove uses of 'first_cpu'
> > > >     qtest/fuzz: Remove uses of 'first_cpu'
>
> > > Ping :)
> >
> > Hi!
> >
> > Good that you pinged, I thought you were looking into the test failures
> > from v1. I copied you in this other thread that mentioned them as well:
> >
> > https://lore.kernel.org/r/87y10jctbd.fsf@suse.de
> >
> > Applying this series on top of master just now:
> >
> > Summary of Failures:
> >
> >   10/519 qemu:qtest+qtest-arm / qtest-arm/stm32l4x5_usart- 
> > test               ERROR            1.40s   exit status 1
> > 165/519 qemu:qtest+qtest-arm / qtest-arm/sse-timer- 
> > test                     ERROR            0.40s   killed by signal 6 SIGABRT
> > 185/519 qemu:qtest+qtest-arm / qtest-arm/stm32l4x5_exti- 
> > test                ERROR            0.19s   exit status 1
> > 187/519 qemu:qtest+qtest-arm / qtest-arm/stm32l4x5_rcc- 
> > test                 ERROR            0.19s   exit status 1
> > 515/519 qemu:qtest+qtest-arm / qtest-arm/microbit- 
> > test                      TIMEOUT         60.01s   killed by signal 15 
> > SIGTERM
>
> Hmm interesting, I have a "quick-before-posting-series" set
> of tests, and a "full-before-posting-pullreq" one. The quick
> is quite extensive, but only include Aarch64. I thought, since
> it contains the ARM targets, they would also be tested, but
> no...

IIRC this was a deliberate decision once in the past to avoid double 
testing: qtests_aarch64 in tests/qtest/meson.build does not include 
qtest_arm, it's a separate set of tests indeed.

IMHO it's a little bit unfortunate, since in a couple of spots in the CI, we 
are taking the shortcut of only adding aarch64-softmmu to the target list, 
but not arm-softmmu.

Maybe we should add some logic to tests/qtest/meson.build so that if 
arm-softmmu is not in target_dirs, we add the tests to qtests_aarch64 ?

 Thomas