Re: [RFC PATCH 1/6] target: Only link capstone to targets requiring it

[Richard Henderson]

On 1/3/25 15:17, Philippe Mathieu-Daudé wrote:
> No need to link capstone to targets which don't use it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   disas/meson.build        | 1 -
>   target/arm/meson.build   | 1 +
>   target/i386/meson.build  | 1 +
>   target/ppc/meson.build   | 1 +
>   target/s390x/meson.build | 1 +
>   5 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/disas/meson.build b/disas/meson.build
> index bbfa1197835..4e80adf36ae 100644
> --- a/disas/meson.build
> +++ b/disas/meson.build
> @@ -20,4 +20,3 @@ common_ss.add(when: 'CONFIG_TCG', if_true: files(
>   ))
>   common_ss.add(files('disas-common.c'))
>   system_ss.add(files('disas-mon.c'))
> -specific_ss.add(capstone)

You need to think about which hosts require capstone as well,
which is most of them.  This will help almost never.


r~