RE: [PATCH 5/5] docs: aspeed: Add ast2700-fc machine section

[Steven Lee]

Hi Cédric,

> -----Original Message-----
> From: Cédric Le Goater <clg@kaod.org>
> Sent: Thursday, January 2, 2025 4:44 PM
> To: Steven Lee <steven_lee@aspeedtech.com>; Peter Maydell
> <peter.maydell@linaro.org>; Troy Lee <leetroy@gmail.com>; Jamin Lin
> <jamin_lin@aspeedtech.com>; Andrew Jeffery
> <andrew@codeconstruct.com.au>; Joel Stanley <joel@jms.id.au>; open
> list:ASPEED BMCs <qemu-arm@nongnu.org>; open list:All patches CC here
> <qemu-devel@nongnu.org>
> Cc: Troy Lee <troy_lee@aspeedtech.com>; Yunlin Tang
> <yunlin.tang@aspeedtech.com>
> Subject: Re: [PATCH 5/5] docs: aspeed: Add ast2700-fc machine section
> 
> On 12/25/24 03:03, Steven Lee wrote:
> > This commit adds a section describing the ast2700-fc multi-SoC machine.
> >
> > Signed-off-by: Steven Lee <steven_lee@aspeedtech.com>
> > ---
> >   docs/system/arm/aspeed.rst | 50
> ++++++++++++++++++++++++++++++++++++--
> >   1 file changed, 48 insertions(+), 2 deletions(-)
> >
> > diff --git a/docs/system/arm/aspeed.rst b/docs/system/arm/aspeed.rst
> > index fa4aa28eef..4b4200a4a5 100644
> > --- a/docs/system/arm/aspeed.rst
> > +++ b/docs/system/arm/aspeed.rst
> > @@ -1,5 +1,5 @@
> > -Aspeed family boards (``ast2500-evb``, ``ast2600-evb``,
> > ``ast2700-evb``, ``bletchley-bmc``, ``fuji-bmc``, ``fby35-bmc``,
> > ``fp5280g2-bmc``, ``g220a-bmc``, ``palmetto-bmc``,
> > ``qcom-dc-scm-v1-bmc``, ``qcom-firework-bmc``, ``quanta-q71l-bmc``,
> > ``rainier-bmc``, ``romulus-bmc``, ``sonorapass-bmc``,
> > ``supermicrox11-bmc``, ``supermicrox11spi-bmc``, ``tiogapass-bmc``,
> > ``tacoma-bmc``, ``witherspoon-bmc``, ``yosemitev2-bmc``)
> >
> -===============================================================
> ======
> >
> ================================================================
> ======
> >
> ================================================================
> ======
> >
> ================================================================
> ======
> >
> ================================================================
> ======
> >
> ================================================================
> =====
> > +Aspeed family boards (``ast2500-evb``, ``ast2600-evb``,
> > +``ast2700-evb``, ``ast2700-evb``, ``bletchley-bmc``, ``fuji-bmc``,
> > +``fby35-bmc``, ``fp5280g2-bmc``, ``g220a-bmc``, ``palmetto-bmc``,
> > +``qcom-dc-scm-v1-bmc``, ``qcom-firework-bmc``, ``quanta-q71l-bmc``,
> > +``rainier-bmc``, ``romulus-bmc``, ``sonorapass-bmc``,
> > +``supermicrox11-bmc``, ``supermicrox11spi-bmc``, ``tiogapass-bmc``,
> > +``tacoma-bmc``, ``witherspoon-bmc``, ``yosemitev2-bmc``)
> >
> +===============================================================
> ======
> >
> +===============================================================
> ======
> >
> +===============================================================
> ======
> >
> +===============================================================
> ======
> >
> +===============================================================
> ======
> >
> +===============================================================
> ======
> > +=====================
> >
> >   The QEMU Aspeed machines model BMCs of various OpenPOWER
> systems and
> >   Aspeed evaluation boards. They are based on different releases of
> > the @@ -42,6 +42,7 @@ AST2600 SoC based machines :
> >   AST2700 SoC based machines :
> >
> >   - ``ast2700-evb``          Aspeed AST2700 Evaluation board
> (Cortex-A35)
> > +- ``ast2700-fc``           Aspeed AST2700 Evaluation board featuring full
> core support (Cortex-A35 + Cortex-M4)
> >
> >   Supported devices
> >   -----------------
> > @@ -270,6 +271,51 @@ Boot the AST2700 machine from the flash image,
> use an MTD drive :
> >          -drive file=${IMGDIR}/image-bmc,format=raw,if=mtd \
> >          -nographic
> >
> > +Booting the ast2700-fc machine
> > +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> A description of the machine would be helpful.
> 

Thanks for the review.
Will add description for the machine.

> Thanks,
> 
> C.
> 
> 
> > +Boot the AST2700 machine from the flash image, use an MTD drive :
> > +
> > +.. code-block:: bash
> > +
> > +  IMGDIR=./
> > +  UBOOT_SIZE=$(stat --format=%s -L ${IMGDIR}/u-boot-nodtb.bin)
> > +
> > +  $ UBOOT_SIZE=$(stat --format=%s -L ${IMGDIR}/u-boot-nodtb.bin)  $
> > + wget
> > + https://github.com/stevenlee7189/zephyr/releases/download/1.0.0/ast2
> > + 700-ssp.elf  $ wget
> > + https://github.com/stevenlee7189/zephyr/releases/download/1.0.0/ast2
> > + 700-tsp.elf  $ wget
> > + https://github.com/stevenlee7189/zephyr/releases/download/1.0.0/bl31
> > + .bin  $ wget
> > + https://github.com/stevenlee7189/zephyr/releases/download/1.0.0/tee-
> > + raw.bin  $ wget
> > + https://github.com/stevenlee7189/zephyr/releases/download/1.0.0/u-bo
> > + ot-nodtb.bin  $ wget
> > + https://github.com/stevenlee7189/zephyr/releases/download/1.0.0/u-bo
> > + ot.dtb  $ wget
> > + https://github.com/stevenlee7189/zephyr/releases/download/1.0.0/imag
> > + e-bmc.tar.zst  $ tar --zstd -xvf image-bmc.tar.zst
> > +
> > +  $ qemu-system-aarch64 -machine ast2700fc \
> > +       -device
> loader,force-raw=on,addr=0x400000000,file=${IMGDIR}/u-boot-nodtb.bin \
> > +       -device loader,force-raw=on,addr=$((0x400000000 +
> ${UBOOT_SIZE})),file=${IMGDIR}/u-boot.dtb \
> > +       -device
> loader,force-raw=on,addr=0x430000000,file=${IMGDIR}/bl31.bin \
> > +       -device
> loader,force-raw=on,addr=0x430080000,file=${IMGDIR}/tee-raw.bin \
> > +       -device loader,file=${IMGDIR}/ast2700-ssp.elf,cpu-num=4 \
> > +       -device loader,file=${IMGDIR}/ast2700-tsp.elf,cpu-num=5 \
> > +       -device loader,cpu-num=0,addr=0x430000000 \
> > +       -device loader,cpu-num=1,addr=0x430000000 \
> > +       -device loader,cpu-num=2,addr=0x430000000 \
> > +       -device loader,cpu-num=3,addr=0x430000000 \
> > +       -m 1G \
> > +       -drive file=image-bmc,if=mtd,format=raw \
> > +       -serial pty -serial pty -serial pty \
> > +       -S -nographic
> > +
> > +    char device redirected to /dev/pts/51 (label serial0)
> > +    char device redirected to /dev/pts/52 (label serial1)
> > +    char device redirected to /dev/pts/53 (label serial2)
> > +
> > +  $ tio /dev/pts/51
> > +  $ tio /dev/pts/52
> > +  $ tio /dev/pts/53
> > +  $ (qemu) c
> > +
> >   Aspeed minibmc family boards (``ast1030-evb``)
> >
> ================================================================
> ==
> >