[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/10] tests/functional/test_vnc: Do not use a hard-coded VNC port
From: |
Thomas Huth |
Subject: |
[PULL 03/10] tests/functional/test_vnc: Do not use a hard-coded VNC port |
Date: |
Thu, 2 Jan 2025 11:31:31 +0100 |
Two tests here are using the hard-coded VNC port :0 ... if there
is already a QEMU or other program running that is using this
port, the tests will be failing. Fortunately, QEMU can also
auto-detect a free port with the "to=..." parameter, so let's
use that for the tests to avoid the problem.
Message-ID: <20241218131439.255841-4-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/functional/test_vnc.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/functional/test_vnc.py b/tests/functional/test_vnc.py
index b769d3b268..e6328567c7 100755
--- a/tests/functional/test_vnc.py
+++ b/tests/functional/test_vnc.py
@@ -72,7 +72,7 @@ def test_no_vnc_change_password(self):
'Could not set password')
def test_change_password_requires_a_password(self):
- self.vm.add_args('-nodefaults', '-S', '-vnc', ':0')
+ self.vm.add_args('-nodefaults', '-S', '-vnc', ':1,to=999')
self.vm.launch()
self.assertTrue(self.vm.qmp('query-vnc')['return']['enabled'])
set_password_response = self.vm.qmp('change-vnc-password',
@@ -84,7 +84,7 @@ def test_change_password_requires_a_password(self):
'Could not set password')
def test_change_password(self):
- self.vm.add_args('-nodefaults', '-S', '-vnc', ':0,password=on')
+ self.vm.add_args('-nodefaults', '-S', '-vnc', ':1,to=999,password=on')
self.vm.launch()
self.assertTrue(self.vm.qmp('query-vnc')['return']['enabled'])
self.vm.cmd('change-vnc-password',
--
2.47.1
- [PULL 00/10] Functional test improvements and fixes, Thomas Huth, 2025/01/02
- [PULL 01/10] docs: update copyright date to the year 2025, Thomas Huth, 2025/01/02
- [PULL 03/10] tests/functional/test_vnc: Do not use a hard-coded VNC port,
Thomas Huth <=
- [PULL 02/10] tests/functional: Convert the vnc test, Thomas Huth, 2025/01/02
- [PULL 04/10] tests/functional/test_vnc: Remove the test_no_vnc test, Thomas Huth, 2025/01/02
- [PULL 05/10] tests/functional: Extract the find_free_ports() function into a helper file, Thomas Huth, 2025/01/02
- [PULL 07/10] tests/functional/test_ppc64_hv: Update repo management, Thomas Huth, 2025/01/02
- [PULL 06/10] tests/functional/test_ppc64_hv: Simplify console handling, Thomas Huth, 2025/01/02
- [PULL 08/10] tests/functional/test_ppc64_hv: Update to Alpine 3.21.0, Thomas Huth, 2025/01/02
- [PULL 10/10] tests/functional/test_arm_quanta_gsj: Fix broken test, Thomas Huth, 2025/01/02
- [PULL 09/10] tests/functional/test_rx_gdbsim: Use stable URL for test_linux_sash, Thomas Huth, 2025/01/02
- Re: [PULL 00/10] Functional test improvements and fixes, Stefan Hajnoczi, 2025/01/02