Re: [PATCH] ui/console-vc: Silence warning about sprintf() on OpenBSD

[Michael Tokarev]

On 14.10.2024 18:15, Daniel P. Berrangé wrote:

> These two lines are the only place in the code that uses the
>
>     char response[40];
>
> so even better than switching to snprintf, how about just taking
> buffer size out of the picture:
>
>    g_autofree *response =
>        g_strdup_printf("\033[%d;%dR",
>                        (s->y_base + s->y) % s->total_height + 1,
>                        s->x + 1);
>    vc_respond_str(vc, response);

What's the reason to perform memory allocation in trivial places
like this?  If we're worrying about possible buffer size issue,
maybe asprintf() is a better alternative for such small things?
Fragmenting heap memory for no reason seems too much overkill.
But I'm old-scool, so.. :)

/mjt