[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 09/22] hw/vhost-scsi: fix -Werror=maybe-uninitialized
From: |
marcandre . lureau |
Subject: |
[PATCH v3 09/22] hw/vhost-scsi: fix -Werror=maybe-uninitialized |
Date: |
Mon, 30 Sep 2024 12:14:44 +0400 |
From: Marc-André Lureau <marcandre.lureau@redhat.com>
../hw/scsi/vhost-scsi.c:173:12: error: ‘ret’ may be used uninitialized
[-Werror=maybe-uninitialized]
It can be reached when num_queues=0. It probably doesn't make much sense
to instantiate a vhost-scsi with 0 IO queues though. For now, make
vhost_scsi_set_workers() return success/0 anyway, when no workers have
been setup.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
---
hw/scsi/vhost-scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
index 49cff2a0cb..22d16dc26b 100644
--- a/hw/scsi/vhost-scsi.c
+++ b/hw/scsi/vhost-scsi.c
@@ -172,7 +172,7 @@ static int vhost_scsi_set_workers(VHostSCSICommon *vsc,
bool per_virtqueue)
struct vhost_dev *dev = &vsc->dev;
struct vhost_vring_worker vq_worker;
struct vhost_worker_state worker;
- int i, ret;
+ int i, ret = 0;
/* Use default worker */
if (!per_virtqueue || dev->nvqs == VHOST_SCSI_VQ_NUM_FIXED + 1) {
--
2.45.2.827.g557ae147e6
- [PATCH v3 06/22] block/mirror: fix -Werror=maybe-uninitialized false-positive, (continued)
- [PATCH v3 06/22] block/mirror: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/30
- [PATCH v3 04/22] nbd: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/30
- [PATCH v3 07/22] block/stream: fix -Werror=maybe-uninitialized false-positives, marcandre . lureau, 2024/09/30
- [PATCH v3 08/22] hw/ahci: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/30
- [PATCH v3 11/22] block/block-copy: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/30
- [PATCH v3 12/22] migration: fix -Werror=maybe-uninitialized false-positives, marcandre . lureau, 2024/09/30
- [PATCH v3 10/22] hw/sdhci: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/30
- [PATCH v3 09/22] hw/vhost-scsi: fix -Werror=maybe-uninitialized,
marcandre . lureau <=
- [PATCH v3 14/22] migration: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/30
- [PATCH v3 21/22] qom/object: fix -Werror=maybe-uninitialized, marcandre . lureau, 2024/09/30
- [PATCH v3 05/22] block/mirror: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/30
- [PATCH v3 18/22] hw/virtio: fix -Werror=maybe-uninitialized, marcandre . lureau, 2024/09/30
- [PATCH v3 17/22] tests: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/30
- [PATCH v3 16/22] target/loongarch: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/30
- [PATCH v3 13/22] hw/virtio-blk: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/30
- [PATCH v3 19/22] RFC: hw/virtio: a potential leak fix, marcandre . lureau, 2024/09/30